linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c: 2 * strange tests ?

From	David Binderman <linuxdev.baldrick@gmail.com>
Newsgroups	linux.kernel
Subject	linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c: 2 * strange tests ?
Date	2016-06-13 18:50 +0200
Message-ID	<rJDdM-ph-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello there,

1.

linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c:798]:
(warning) Comparison of a boolean expression with an integer other
than 0 or 1.

Source code is

   if (common->ani.caldone <= 0) {

but

drivers/net/wireless/ath/ath.h:    bool caldone;

Maybe better code

  if (!(common->ani.caldone)) {

2.

linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c:851]:
(warning) Comparison of a boolean expression with an integer other
than 0 or 1.

   if (common->ani.caldone <= 0)

Duplicate. Also in the same file:

drivers/net/wireless/ath/ath9k/htc_drv_main.c:228]: (style) Variable
'ret' is assigned a value that is never used.

This might be a case where a function return value is not checked.

Regards

David Binderman

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c: 2 *  strange tests ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-13 18:50 +0200

csiph-web