Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1421048
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Binderman <linuxdev.baldrick@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c: 2 * strange tests ? |
| Date | Mon, 13 Jun 2016 18:50:02 +0200 |
| Message-ID | <rJDdM-ph-3@gated-at.bofh.it> (permalink) |
| X-Original-To | ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=Dc/SnJI1VYefQdNJa8g/2aoVzQCLGybYDZocpcRj86A=; b=cLgHMY2n+cPDMb8HTi3dE2SU11OWpMQzLL3daEwQWHLAqdrYQvUAjjEQ0p63SyiCNq 8mUv4ATwRNXaNFnwFovZ0NRxzusNb9+9ukZWF0aORZkK3Z5DWH3nE86cP4rQe+C1335Q gJ6Vg0LH5CxNF9AkKZykVTW6BRm1CBEl+Xh7wbYOR7TbqCMKaXg+OlGiCrRm5dSgOpS9 odKWb0Ia8zT/rDKADL0gA8+JCbd9Utt4Qd0CesqeVrAm2A1U+7F142Dz94/N7o/Kv1/V 1kJdXD70CYetJIqGU2PJNOMqiHV0Zzs2rp/ACfnuJABaEPulEsdoj4026xMP0sYdZu8u s/3g== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Dc/SnJI1VYefQdNJa8g/2aoVzQCLGybYDZocpcRj86A=; b=gPBjsrEdX/rqVIHwF6QLQvoiKQu0o7MJNSuBtqLH1rqYtNuuD9R9CobFPps6Wx0xKO dRiyMa0VAH+rUPPzLocvADmLPK6pvv6unmMs7RHhMXMPp4o8I2n0mQgALAX1LkwJpxUs UlQdNllLF/nqBRh5mag8Jb0e3tpGHo0x5/EUK1n8UKWfgjx5TCRv01VBYl+6iBCFEaBE Vcx+scLX7xGuWuQkHre/uxYnJbqhb6l1ZK7r937yyTqds/MEwqshFExRyQzg5Fr6qIpp UNW0lp/V05X8NryfqHanzE68VrdTwXpX9wMGOvAwuH0hPnpa1MzHCKjpzW4MY8nyoVvj zP8g== |
| X-Gm-Message-State | ALyK8tJwhlccFlT6CMOyqN7v75SNc41cwG+/Wx3bT7qNLkhWS6ydgOhxDmgxyKvj4NUVWvvwrG5FQW/GE8c6aA== |
| X-Received | by 10.107.43.206 with SMTP id r197mr24150187ior.81.1465836156232; Mon, 13 Jun 2016 09:42:36 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Date | Mon, 13 Jun 2016 17:42:35 +0100 |
| X-Original-Message-ID | <CAMzoamZjA4XfL1b5Hqo7F+97PY-MEaijJ24iY+53L9ntNZromw@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1421048 |
Show key headers only | View raw
Hello there,
1.
linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c:798]:
(warning) Comparison of a boolean expression with an integer other
than 0 or 1.
Source code is
if (common->ani.caldone <= 0) {
but
drivers/net/wireless/ath/ath.h: bool caldone;
Maybe better code
if (!(common->ani.caldone)) {
2.
linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c:851]:
(warning) Comparison of a boolean expression with an integer other
than 0 or 1.
if (common->ani.caldone <= 0)
Duplicate. Also in the same file:
drivers/net/wireless/ath/ath9k/htc_drv_main.c:228]: (style) Variable
'ret' is assigned a value that is never used.
This might be a case where a function return value is not checked.
Regards
David Binderman
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
linux-4.7-rc3/drivers/net/wireless/ath/ath9k/htc_drv_main.c: 2 * strange tests ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-13 18:50 +0200
csiph-web