Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416209
| From | Mel Gorman <mgorman@techsingularity.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression |
| Date | 2016-06-07 15:50 +0200 |
| Message-ID | <rHpyi-3ll-47@gated-at.bofh.it> (permalink) |
| References | <rG6el-KI-3@gated-at.bofh.it> <rG6el-KI-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 03, 2016 at 05:58:40PM -0500, Josh Poimboeuf wrote:
> Commit cb2517653fcc ("sched/debug: Make schedstats a runtime tunable
> that is disabled by default") introduced a bug when CONFIG_SCHEDSTATS is
> enabled and the runtime tunable is disabled (which is the default). The
> wait-time, sum-exec, and sum-sleep fields are missing from the
> /proc/sched_debug file in the runnable_tasks section.
>
I take it that this breaks userspace parsing?
> Fix it with a new schedstat_val() macro which returns the field value
> when schedstats is enabled and zero otherwise. The macro works with
> both SCHEDSTATS and !SCHEDSTATS. I put the macro in stats.h since it
> might end up being useful in other places.
>
> Fixes: cb2517653fcc ("sched/debug: Make schedstats a runtime tunable that is disabled by default")
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-04 01:00 +0200
Re: [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression Mel Gorman <mgorman@techsingularity.net> - 2016-06-07 15:50 +0200
Re: [PATCH v2 1/2] sched/debug: fix /proc/sched_debug regression Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-07 20:00 +0200
[tip:sched/core] sched/debug: Fix /proc/sched_debug regression tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2016-06-08 16:30 +0200
csiph-web