Re: [PATCH] loop: Make user notify for adding loop device failed

From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] loop: Make user notify for adding loop device failed
Date	2016-06-07 15:50 +0200
Message-ID	<rHpyi-3ll-37@gated-at.bofh.it> (permalink)
References	<rHeCR-4O2-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Minfei Huang <mnghuan@gmail.com> writes:

> There is no error number returned if loop driver fails in function
> alloc_disk to add new loop device. Add a correct error number to make
> user notify in this case.
>
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
>  drivers/block/loop.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 1fa8cc2..2caaf6f 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1765,6 +1765,7 @@ static int loop_add(struct loop_device **l, int i)
>  	 */
>  	queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue);
>  
> +	err = -ENOMEM;
>  	disk = lo->lo_disk = alloc_disk(1 << part_shift);
>  	if (!disk)
>  		goto out_free_queue;

Looks good.

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] loop: Make user notify for adding loop device failed Minfei Huang <mnghuan@gmail.com> - 2016-06-07 04:10 +0200
  Re: [PATCH] loop: Make user notify for adding loop device failed Ming Lei <ming.lei@canonical.com> - 2016-06-07 04:50 +0200
  Re: [PATCH] loop: Make user notify for adding loop device failed Jeff Moyer <jmoyer@redhat.com> - 2016-06-07 15:50 +0200

csiph-web