Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415974

Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb
Date 2016-06-07 12:40 +0200
Message-ID <rHmAq-1vx-51@gated-at.bofh.it> (permalink)
References <rFNlo-5RH-5@gated-at.bofh.it> <rFNlo-5RH-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote:
>
> +	struct ahash_alg *shash = crypto_ahash_alg(tfm);
>  
>  	/* alignment is to be done by multi-buffer crypto algorithm if needed */
>  
> -	return shash->finup(desc, NULL, 0, req->result);
> +	return shash->finup(desc);

You're still poking in the guts of the API.  Now that it's a real
ahash you don't need to do that.

Just do crypto_ahash_finup.  That way you don't need to export
crypto_ahsh_alg either.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 2/2] crypto : async implementation for sha1-mb Megha Dey <megha.dey@intel.com> - 2016-06-03 04:50 +0200
  Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-07 12:40 +0200
    RE: [PATCH V2 2/2] crypto : async implementation for sha1-mb "Dey, Megha" <megha.dey@intel.com> - 2016-06-07 20:20 +0200

csiph-web