Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415975

Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request
Date 2016-06-07 12:40 +0200
Message-ID <rHmAq-1vx-53@gated-at.bofh.it> (permalink)
References <rFAHv-6o5-13@gated-at.bofh.it> <rFAHv-6o5-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 02, 2016 at 03:13:32PM +0200, LABBE Corentin wrote:
>
>  static int omap_aes_prepare_req(struct crypto_engine *engine,
> -				struct ablkcipher_request *req)
> +				struct crypto_async_request *areq)
>  {
> +	struct ablkcipher_request *req = ablkcipher_request_cast(areq);

You're still doing casting in the driver.

I want this to be moved into the crypto engine API.  There should
be separate function pointers for each request type.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-02 15:20 +0200
  [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-02 15:20 +0200
    Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-07 12:40 +0200
      Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-06-10 16:50 +0200

csiph-web