Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417542
| From | Shrikrishna Khare <skhare@vmware.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets |
| Date | 2016-06-08 16:50 +0200 |
| Message-ID | <rHMXT-1pV-5@gated-at.bofh.it> (permalink) |
| References | <rHF0l-4MH-3@gated-at.bofh.it> <rHIKC-7iL-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 8 Jun 2016, Thomas Hellstrom wrote: > > mss = rcdlro->mss; > > if (unlikely(segCnt <= 1)) > > segCnt = 0; > > Based on this code, it looks like it can handle the case without taking > down the kernel completely, so instead of a > "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()? Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent out revised patch.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 08:20 +0200
Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Thomas Hellstrom <thellstrom@vmware.com> - 2016-06-08 12:20 +0200
Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 16:50 +0200
Re: [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets David Miller <davem@davemloft.net> - 2016-06-10 09:20 +0200
csiph-web