Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417542
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Shrikrishna Khare <skhare@vmware.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets |
| Date | Wed, 08 Jun 2016 16:50:01 +0200 |
| Message-ID | <rHMXT-1pV-5@gated-at.bofh.it> (permalink) |
| References | <rHF0l-4MH-3@gated-at.bofh.it> <rHIKC-7iL-13@gated-at.bofh.it> |
| X-Original-To | Thomas Hellstrom <thellstrom@vmware.com> |
| X-X-Sender | skhare@shri-linux.eng.vmware.com |
| User-Agent | Alpine 2.10 (DEB 1266 2009-07-14) |
| MIME-Version | 1.0 |
| Content-Type | TEXT/PLAIN; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 14 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pv-drivers@vmware.com, Jin Heo <heoj@vmware.com> |
| X-Original-Date | Wed, 8 Jun 2016 07:43:16 -0700 (PDT) |
| X-Original-Message-ID | <alpine.DEB.2.10.1606080741541.14228@shri-linux.eng.vmware.com> |
| X-Original-References | <1465366415-124072-1-git-send-email-skhare@vmware.com> <5757EEFC.3060709@vmware.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1417542 |
Show key headers only | View raw
On Wed, 8 Jun 2016, Thomas Hellstrom wrote: > > mss = rcdlro->mss; > > if (unlikely(segCnt <= 1)) > > segCnt = 0; > > Based on this code, it looks like it can handle the case without taking > down the kernel completely, so instead of a > "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()? Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent out revised patch.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 08:20 +0200
Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Thomas Hellstrom <thellstrom@vmware.com> - 2016-06-08 12:20 +0200
Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 16:50 +0200
Re: [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets David Miller <davem@davemloft.net> - 2016-06-10 09:20 +0200
csiph-web