Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410
Date	2016-06-02 08:20 +0200
Message-ID	<rFu94-2i2-7@gated-at.bofh.it> (permalink)
References	<rFaWJ-6IP-9@gated-at.bofh.it> <rFaWJ-6IP-7@gated-at.bofh.it> <rFg65-1A8-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
>> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
>> shared with Exynos5410 and configure the clocks on the latter.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
> 
> [snip]
> 
>>  
>> +&sss {
>> +	clocks = <&clock CLK_SSS>;
>> +	clock-names = "secss";
>> +};
>> +
> 
> [snip]
> 
>>  
>> +&watchdog {
>> +	clocks = <&clock CLK_WDT>;
>> +	clock-names = "watchdog";
>> +	samsung,syscon-phandle = <&pmu_system_controller>;
>> +};
>> +
> 
> Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
> I wonder if the clock and clock-names shouldn't be just defined in the
> shared exynos54xx.dtsi as is the case for the interrupts that are also
> the same?
> 
> The patch looks good to me though, so whatever you decide:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks for review and comments.

The 'clock' property cannot be moved - there is no clock phandle and the
clock IDs are not included in 54xx.

Best regards,
Krzysztof

Thread

[PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to  Exynos5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 11:50 +0200
  Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 17:20 +0200
    Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-02 08:20 +0200
      Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-02 15:30 +0200

csiph-web