Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410
Date	2016-06-02 15:30 +0200
Message-ID	<rFARb-6rl-3@gated-at.bofh.it> (permalink)
References	<rFaWJ-6IP-9@gated-at.bofh.it> <rFaWJ-6IP-7@gated-at.bofh.it> <rFg65-1A8-1@gated-at.bofh.it> <rFu94-2i2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 06/02/2016 02:18 AM, Krzysztof Kozlowski wrote:
> On 06/01/2016 05:16 PM, Javier Martinez Canillas wrote:

[snip]

>>>  
>>> +&watchdog {
>>> +	clocks = <&clock CLK_WDT>;
>>> +	clock-names = "watchdog";
>>> +	samsung,syscon-phandle = <&pmu_system_controller>;
>>> +};
>>> +
>>
>> Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
>> I wonder if the clock and clock-names shouldn't be just defined in the
>> shared exynos54xx.dtsi as is the case for the interrupts that are also
>> the same?
>>
>> The patch looks good to me though, so whatever you decide:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Thanks for review and comments.
> 
> The 'clock' property cannot be moved - there is no clock phandle and the
> clock IDs are not included in 54xx.
>

You are right, I missed that. Thanks a lot for the clarification.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to  Exynos5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 11:50 +0200
  Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-01 17:20 +0200
    Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-02 08:20 +0200
      Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem  to Exynos5410 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-02 15:30 +0200

csiph-web