Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407766

Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller

Show all headers | View raw

On Wed, May 25, 2016 at 11:17:08AM +0100, Mark Brown wrote:
> On Wed, May 25, 2016 at 05:43:03AM +0000, Rich Felker wrote:
> 
> > changes based on ml discussion of the v2 patch. The chipselect change
> > has not been made yet, except for rewriting the current logic to be
> > more clear. If the decision is that it's needed, I can do it easily,
> > but it needs testing still.
> 
> You need to fix that, it's not good to just decide to ignore review
> comments.  It is astonishing that you are doing this while expecting to
> bypass the normal process for merging things.  I'm not going to look at
> this version, please ensure you have addressed all the feedback from the
> previous review before any new version you submit.

I've made and tested a change that looks like what you want, with the
hw->csReg's chipselect bits set initially high in the probe function,
and only the requested bit being modified by the chipselect function.
Would you prefer I continue to submit this driver with new versions of
the patch series, or separate it out for further review on its own?

Rich

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 10/12] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-05-25 12:20 +0200
      Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-05-27 03:20 +0200
        Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-05-27 13:40 +0200
  [PATCH v3 11/12] sh: add defconfig for J-Core J2 Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 05/12] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 05/12] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-05-25 21:20 +0200
  [PATCH v3 04/12] of: add J-Core timer bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 09/12] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 01/12] of: add vendor prefix for J-Core Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 01/12] of: add vendor prefix for J-Core Rob Herring <robh+dt@kernel.org> - 2016-05-25 15:20 +0200
  [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2  board Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas  v2  board Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:40 +0200
      Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas  v2  board Rich Felker <dalias@libc.org> - 2016-05-26 01:20 +0200
        Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas  v2  board Mark Rutland <mark.rutland@arm.com> - 2016-05-26 12:40 +0200
  [PATCH v3 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 03/12] of: add J-Core interrupt controller bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:30 +0200
      Re: [PATCH v3 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-26 01:10 +0200
  [PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
    Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:30 +0200
      Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-26 01:10 +0200
        Re: [PATCH v3 02/12] of: add J-Core cpu bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-26 10:00 +0200
        Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-26 12:40 +0200
          Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-26 17:40 +0200
            Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-27 11:20 +0200
        Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rob Landley <rob@landley.net> - 2016-05-26 23:50 +0200
          Re: [PATCH v3 02/12] of: add J-Core cpu bindings Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2016-05-27 14:00 +0200
  [PATCH v3 08/12] irqchip: add J-Core AIC driver Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 07/12] sh: add AT_HWCAP flag for J-Core cas.l instruction Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  [PATCH v3 06/12] sh: add support for J-Core J2 processor Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
  Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 09:30 +0200
  Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Mark Brown <broonie@kernel.org> - 2016-05-25 12:00 +0200
    Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Rich Felker <dalias@libc.org> - 2016-05-26 00:30 +0200
      Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Mark Brown <broonie@kernel.org> - 2016-05-26 02:50 +0200

csiph-web