Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1407288
| From | Rich Felker <dalias@libc.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board |
| Date | 2016-05-26 01:20 +0200 |
| Message-ID | <rCQfL-727-5@gated-at.bofh.it> (permalink) |
| References | <rCzRD-5z7-3@gated-at.bofh.it> <rCzRD-5z7-15@gated-at.bofh.it> <rCEoi-8jG-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, May 25, 2016 at 11:33:50AM +0100, Mark Rutland wrote:
> On Wed, May 25, 2016 at 05:43:03AM +0000, Rich Felker wrote:
> > Signed-off-by: Rich Felker <dalias@libc.org>
> > ---
> > arch/sh/boot/dts/j2_mimas_v2.dts | 87 ++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 87 insertions(+)
> > create mode 100755 arch/sh/boot/dts/j2_mimas_v2.dts
> >
> > diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
> > new file mode 100755
> > index 0000000..4a66cda
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
> > @@ -0,0 +1,87 @@
> > +/dts-v1/;
> > +
> > +/ {
> > + compatible = "jcore,j2-soc";
> > + model = "J2 FPGA SoC on Mimas v2 board";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + interrupt-parent = <&aic>;
> > +
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + cpu@0 {
> > + device_type = "cpu";
> > + compatible = "jcore,j2";
> > + reg = < 0 >;
> > + clock-frequency = < 50000000 >;
>
> Nit: please remove the spacing around the '<' and '>' here. If nothing
> else, it's inconsistent with the rest of this file.
>
> > + };
> > + };
> > +
> > + memory@10000000 {
> > + device_type = "memory";
> > + reg = < 0x10000000 0x4000000 >;
> > + };
>
> Likewise.
OK, I'll change both of these.
> > +
> > + chosen {
> > + stdout-path = "/soc@abcd0000/serial@100";
> > + };
>
> Please use a label for the serial node, have an alias, and describe the
> pre-configured rate per the stdout-path binding, e.g.
Per Documentation/devicetree/bindings/xilinx.txt, current-speed is a
required property for "xlnx,xps-uartlite-1.00.a". Note that uartlite
does not actually have a programmable baud rate; the property is
instead being used to describe the hardware-provided rate.
BTW our uartlite is not actually derived from Xilinx's IP core, just
interface-compatible with it, so I'd actually like to add a
"jcore,uartlite" binding too in order to express this, with
"xlnx,xps-uartlite-1.00.a" as the fallback compatible-tag. I'll
propose that as a separate patch later.
Rich
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 10/12] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-05-25 12:20 +0200
Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-05-27 03:20 +0200
Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-05-27 13:40 +0200
[PATCH v3 11/12] sh: add defconfig for J-Core J2 Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 05/12] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 05/12] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-05-25 21:20 +0200
[PATCH v3 04/12] of: add J-Core timer bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 09/12] clocksource: add J-Core timer/clocksource driver Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 01/12] of: add vendor prefix for J-Core Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 01/12] of: add vendor prefix for J-Core Rob Herring <robh+dt@kernel.org> - 2016-05-25 15:20 +0200
[PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:40 +0200
Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board Rich Felker <dalias@libc.org> - 2016-05-26 01:20 +0200
Re: [PATCH v3 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board Mark Rutland <mark.rutland@arm.com> - 2016-05-26 12:40 +0200
[PATCH v3 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 03/12] of: add J-Core interrupt controller bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:30 +0200
Re: [PATCH v3 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-26 01:10 +0200
[PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-25 12:30 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-26 01:10 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-26 10:00 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-26 12:40 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rich Felker <dalias@libc.org> - 2016-05-26 17:40 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Mark Rutland <mark.rutland@arm.com> - 2016-05-27 11:20 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Rob Landley <rob@landley.net> - 2016-05-26 23:50 +0200
Re: [PATCH v3 02/12] of: add J-Core cpu bindings Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2016-05-27 14:00 +0200
[PATCH v3 08/12] irqchip: add J-Core AIC driver Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 07/12] sh: add AT_HWCAP flag for J-Core cas.l instruction Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
[PATCH v3 06/12] sh: add support for J-Core J2 processor Rich Felker <dalias@libc.org> - 2016-05-25 07:50 +0200
Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-25 09:30 +0200
Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Mark Brown <broonie@kernel.org> - 2016-05-25 12:00 +0200
Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Rich Felker <dalias@libc.org> - 2016-05-26 00:30 +0200
Re: [PATCH v3 00/12] J-core J2 cpu and SoC peripherals support Mark Brown <broonie@kernel.org> - 2016-05-26 02:50 +0200
csiph-web