Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406261

Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend

Show all headers | View raw

+mjg59, who may be seeing this issue on a skylake laptop

Chen-yu,

Great debugging, but I think there is a more general fix possible than
this DMI quirk.

I agree that in this example, a grantley server, it seems the BIOS is
erroneously
returning a bogus value of MSR_IA32_THERM_CONTROL on resume from S3.

But another scenario is also possible.  Consider a laptop that is resuming HOT
and the BIOS correctly enables throttling.  If this code were invoked, it would
restore the COLD setting.

Instead, it seems to me that the ACPI processor driver should upon .resume
check if throttling should be enabled or not, and proceed accordingly.
That would always do the "right thing", and would not need a DMI list.
Does that make sense?

thanks,
Len Brown, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend Len Brown <lenb@kernel.org> - 2016-05-24 18:20 +0200
  Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend Chen Yu <yu.chen.surf@gmail.com> - 2016-05-25 07:10 +0200

csiph-web