Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Len Brown <lenb@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend
Date	Tue, 24 May 2016 18:20:01 +0200
Message-ID	<rCndL-5Ak-1@gated-at.bofh.it> (permalink)
References	<qypgm-2AY-23@gated-at.bofh.it> <qz0SB-3aI-15@gated-at.bofh.it> <qz6Om-71A-15@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=v4dJdEG9/pSqxov4+uVvDgN8f7VGcjitgDCJLf73t84=; b=JxQ4NIXSt4VyFEw9uWgUxaZX/LYqaM/rdWYZlWV9cawRlM6SIDeLiEnIw3G6K3Z7xh zmpYIWqt5N2Sd8QXW1YOgTt0b9XrRmgjv8jM8hard1WWyE7ljsexxQJqdcEOvTn38z9p iMy/6pFlzNcUNOd5PFOz14jIk4ky8skgzaKPMIYnSJv8NRyAl4G23UE/Flo+5zDJWDwn /vSqp4TI8UOjXm7mC9BCMA0QFKh0ik6QaRQr513zcCQu4sndSAF3oslUq007DeSEpXwz 3O/+4K8ZDDLZX48XqPFm/Yl8ZpWs4KdI8KM0O7+HJ4ceMCRQKpUSgZxjAHOK3vMqPPOU WFkA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=v4dJdEG9/pSqxov4+uVvDgN8f7VGcjitgDCJLf73t84=; b=aWqvLV0GxjuYnWMd1ZlqPRLpt8lmQW6ZEAtqb3+tOCA81c+Jl76fNqWxH1voIcnXVI 22cgW9SIhUHMwYm34KYDna5V0fMztNHEm47sIfeVLfe7//pm0duEsGxMBippKlFtUUsr nrHLvW6intSiEdT8lk6fkChX8yzgdsprhGKiTBPZXfuZP+Ibiu148iLO1WMLC6Y517Dx pxeHoPeplIJqwBIgJ6JmF1uljwq7/a0SQMGUR9sE/od+aMypxv+eq7tQq56fcsPc8FZe hEVmnwHV9SR+NfV0bdZkY0yl3HVYDlqbinvi439OsEL2r2kMao1MRKEKgiDMK7YlX7MD AMrA==
X-Gm-Message-State	ALyK8tIGTGURoSrpYLn+jSnSIOUT2lABnG2llg3OAufrNB72a2MxorofADN0wTgzgjbbMd4VGszuV4TofVIoLg==
MIME-Version	1.0
X-Received	by 10.55.170.200 with SMTP id t191mr4258770qke.100.1464106196804; Tue, 24 May 2016 09:09:56 -0700 (PDT)
X-Google-Sender-Auth	kWUh3vwVeeUx_5E0LFtfIHl47UQ
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Ingo Molnar <mingo@kernel.org>, "mingo@redhat.com" <mingo@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "hpa@zytor.com" <hpa@zytor.com>, "rjw@rjwysocki.net" <rjw@rjwysocki.net>, "pavel@ucw.cz" <pavel@ucw.cz>, "Brown, Len" <len.brown@intel.com>, "luto@kernel.org" <luto@kernel.org>, "bp@suse.de" <bp@suse.de>, "linux@horizon.com" <linux@horizon.com>, "Kaszewski, Marcin" <marcin.kaszewski@intel.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Matthew Garrett <mjg59@srcf.ucam.org>
X-Original-Date	Tue, 24 May 2016 12:09:56 -0400
X-Original-Message-ID	<CAJvTdKn9XyutRAk4Hf5tarQVkCQ4QQL3wtM5RHYfsMg8P3mhnA@mail.gmail.com>
X-Original-References	<c9abdcbc173dd2f57e8990e304376f19287e92ba.1448382971.git.yu.c.chen@intel.com> <20151126090940.GA30403@gmail.com> <36DF59CE26D8EE47B0655C516E9CE64028677FF5@shsmsx102.ccr.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1406261

Show key headers only | View raw

+mjg59, who may be seeing this issue on a skylake laptop

Chen-yu,

Great debugging, but I think there is a more general fix possible than
this DMI quirk.

I agree that in this example, a grantley server, it seems the BIOS is
erroneously
returning a bogus value of MSR_IA32_THERM_CONTROL on resume from S3.

But another scenario is also possible.  Consider a laptop that is resuming HOT
and the BIOS correctly enables throttling.  If this code were invoked, it would
restore the COLD setting.

Instead, it seems to me that the ACPI processor driver should upon .resume
check if throttling should be enabled or not, and proceed accordingly.
That would always do the "right thing", and would not need a DMI list.
Does that make sense?

thanks,
Len Brown, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend Len Brown <lenb@kernel.org> - 2016-05-24 18:20 +0200
  Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend Chen Yu <yu.chen.surf@gmail.com> - 2016-05-25 07:10 +0200

csiph-web