RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl

From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl
Date	2016-05-24 11:00 +0200
Message-ID	<rCgm3-12f-35@gated-at.bofh.it> (permalink)
References	<rwE7E-6aJ-9@gated-at.bofh.it> <rBXMm-6ir-17@gated-at.bofh.it> <rC5Ae-2Hk-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> 
> On Mon, May 23, 2016 at 01:07:53PM +0000, Winkler, Tomas wrote:
> > >
> > > From: Alexander Usyskin <alexander.usyskin@intel.com>
> > >
> > > wr_ctrl waiters are none interruptible, so should be waken up with
> > > call to wake_up and not to wake_up_interruptible.
> > >
> > > This fixes commit:
> > > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.")
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > Hi Greg,
> > I see this fix didn't make it to rc1, so currently the  driver is somehow
> broken.
> > Can you please make an effort and include the fix in next rc?
> 
> Ugh, didn't realize it was totally broken, the patch didn't really say that, sorry.
> I'll queue it up once 4.7-rc1 is out.
> 

There's a big difference between somhow broken and totally broken.
Just couldn't resist to parphrase Miracle Max :There's a big difference between mostly dead and all dead :)

Thanks
Tomas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-05-23 15:10 +0200
  Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-23 23:30 +0200
    RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-05-24 11:00 +0200

csiph-web