Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1405348

RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl

From "Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups linux.kernel
Subject RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl
Date 2016-05-23 15:10 +0200
Message-ID <rBXMm-6ir-17@gated-at.bofh.it> (permalink)
References <rwE7E-6aJ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> 
> From: Alexander Usyskin <alexander.usyskin@intel.com>
> 
> wr_ctrl waiters are none interruptible, so should be waken up with call to
> wake_up and not to wake_up_interruptible.
> 
> This fixes commit:
> 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.")
> 
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Hi Greg,
I see this fix didn't make it to rc1, so currently the  driver is somehow broken.
Can you please make an effort and include the fix in next rc? 

Thanks
Tomas 

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-05-23 15:10 +0200
  Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-23 23:30 +0200
    RE: [char-misc-next 1/2] mei: don't use wake_up_interruptible for  wr_ctrl "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-05-24 11:00 +0200

csiph-web