Re: [PATCH 3/3] ibmvscsis: clean up functions

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ibmvscsis: clean up functions
Date	2016-05-25 16:50 +0200
Message-ID	<rCIid-28x-3@gated-at.bofh.it> (permalink)
References	<rCl2h-3Wi-3@gated-at.bofh.it> <rCHPb-1YV-15@gated-at.bofh.it> <rCHYS-22l-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly <bryantly@linux.vnet.ibm.com>

Please use your whole name here and for your sign-off like:

From: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>

> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixes MAINTAINERS
> for ibmvscsis.

trivial note:

> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c
[]
>  static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba,
>  			       u64 dliobn, u64 dlioba)
>  {
> 

Functions like this would be less indented and less
line wrapped for 80 columns if they were written:

	if (!se_cmd->residual_count)
		return;

	[unindented one level...]

etc...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

IBM VSCSI Target Driver Initial Patch Sets "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> - 2016-05-25 16:20 +0200
  Re: [PATCH 3/3] ibmvscsis: clean up functions Joe Perches <joe@perches.com> - 2016-05-25 16:50 +0200

csiph-web