Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406931 > unrolled thread
| Started by | "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> |
|---|---|
| First post | 2016-05-25 16:20 +0200 |
| Last post | 2016-05-25 16:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
IBM VSCSI Target Driver Initial Patch Sets "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> - 2016-05-25 16:20 +0200
Re: [PATCH 3/3] ibmvscsis: clean up functions Joe Perches <joe@perches.com> - 2016-05-25 16:50 +0200
| From | "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-05-25 16:20 +0200 |
| Subject | IBM VSCSI Target Driver Initial Patch Sets |
| Message-ID | <rCHPb-1YV-15@gated-at.bofh.it> |
This patch series addresses comments by Joe with runing checkpatch with a --strict. It cleans up all the misc styling and removes all the forward declarations. The patch also addresses all of Bart's comments besides the preallocation of buffers before IO starts and the merging of unpack_lun with scsiluntoint. Those will come in later patch sets. [PATCH 2/3] ibmvscsis: Addressing Bart's comments [PATCH 3/3] ibmvscsis: clean up functions
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-05-25 16:50 +0200 |
| Subject | Re: [PATCH 3/3] ibmvscsis: clean up functions |
| Message-ID | <rCIid-28x-3@gated-at.bofh.it> |
| In reply to | #1406931 |
On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly <bryantly@linux.vnet.ibm.com>
Please use your whole name here and for your sign-off like:
From: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixes MAINTAINERS
> for ibmvscsis.
trivial note:
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c
[]
> static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba,
> u64 dliobn, u64 dlioba)
> {
>
Functions like this would be less indented and less
line wrapped for 80 columns if they were written:
if (!se_cmd->residual_count)
return;
[unindented one level...]
etc...
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web