Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask

From	Alexandre Courbot <gnurou@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask
Date	2016-03-04 07:20 +0100
Message-ID	<r8RfH-2o1-1@gated-at.bofh.it> (permalink)
References	<r7KpX-4hl-5@gated-at.bofh.it> <r7KpX-4hl-3@gated-at.bofh.it> <r80bq-6s3-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 2, 2016 at 6:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
>>          */
>> -       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
>> +       if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
>>                 host->dma_mask = DMA_BIT_MASK(64);
>> -               mmc_dev(mmc)->dma_mask = &host->dma_mask;
>> -       }
>> +
>> +       if (host->dma_mask &&
>> +           dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
>> +               pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
>>
>
> Looks good,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Withdrawing this patch after discussing with Arnd. The test detects
devices that are not capable of DMA, so it makes no sense to call a
DMA function right after that.

A better solution to the problem this patch tried to solve is on the way.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] mmc: sdhci: Set DMA mask Alexandre Courbot <acourbot@nvidia.com> - 2016-03-01 05:50 +0100
  Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask Arnd Bergmann <arnd@arndb.de> - 2016-03-01 22:40 +0100
    Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask Alexandre Courbot <gnurou@gmail.com> - 2016-03-04 07:20 +0100

csiph-web