[PATCH] net/ethoc: do not free array priv->mdio->irq

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] net/ethoc: do not free array priv->mdio->irq
Date	2016-03-03 14:50 +0100
Message-ID	<r8BND-7MX-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

priv->mdio->irq used to be allocated and required freeing, but it
is now a fixed sized array and should no longer be free'd.

Issue detected using static analysis with CoverityScan

Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/ethoc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 62fa136..41b0106 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
 
 		if (priv->mdio) {
 			mdiobus_unregister(priv->mdio);
-			kfree(priv->mdio->irq);
 			mdiobus_free(priv->mdio);
 		}
 		if (priv->clk)
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/ethoc: do not free array priv->mdio->irq Colin King <colin.king@canonical.com> - 2016-03-03 14:50 +0100
  Re: [PATCH] net/ethoc: do not free array priv->mdio->irq Tobias Klauser <tklauser@distanz.ch> - 2016-03-03 15:20 +0100
  Re: [PATCH] net/ethoc: do not free array priv->mdio->irq Andrew Lunn <andrew@lunn.ch> - 2016-03-03 15:30 +0100

csiph-web