Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1349167 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-03-03 14:50 +0100 |
| Last post | 2016-03-03 15:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net/ethoc: do not free array priv->mdio->irq Colin King <colin.king@canonical.com> - 2016-03-03 14:50 +0100
Re: [PATCH] net/ethoc: do not free array priv->mdio->irq Tobias Klauser <tklauser@distanz.ch> - 2016-03-03 15:20 +0100
Re: [PATCH] net/ethoc: do not free array priv->mdio->irq Andrew Lunn <andrew@lunn.ch> - 2016-03-03 15:30 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-03-03 14:50 +0100 |
| Subject | [PATCH] net/ethoc: do not free array priv->mdio->irq |
| Message-ID | <r8BND-7MX-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
priv->mdio->irq used to be allocated and required freeing, but it
is now a fixed sized array and should no longer be free'd.
Issue detected using static analysis with CoverityScan
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/ethoc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 62fa136..41b0106 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
if (priv->mdio) {
mdiobus_unregister(priv->mdio);
- kfree(priv->mdio->irq);
mdiobus_free(priv->mdio);
}
if (priv->clk)
--
2.7.0
[toc] | [next] | [standalone]
| From | Tobias Klauser <tklauser@distanz.ch> |
|---|---|
| Date | 2016-03-03 15:20 +0100 |
| Message-ID | <r8CgH-8cy-31@gated-at.bofh.it> |
| In reply to | #1349167 |
On 2016-03-03 at 14:43:34 +0100, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
[toc] | [prev] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-03-03 15:30 +0100 |
| Message-ID | <r8Cqn-8hu-21@gated-at.bofh.it> |
| In reply to | #1349167 |
On Thu, Mar 03, 2016 at 01:43:34PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/ethernet/ethoc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
> index 62fa136..41b0106 100644
> --- a/drivers/net/ethernet/ethoc.c
> +++ b/drivers/net/ethernet/ethoc.c
> @@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
>
> if (priv->mdio) {
> mdiobus_unregister(priv->mdio);
> - kfree(priv->mdio->irq);
> mdiobus_free(priv->mdio);
> }
> if (priv->clk)
> --
> 2.7.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web