Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1346248

Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating

Show all headers | View raw

* Franklin S Cooper Jr. <fcooper@ti.com> [160229 15:12]:
> 
> 
> On 02/29/2016 04:55 PM, Tony Lindgren wrote:
> > * Franklin S Cooper Jr. <fcooper@ti.com> [160229 14:31]:
> >> On 02/29/2016 04:04 PM, Tony Lindgren wrote:
> >>> Hmm but why are you also removing the pm_runtime calls? Those
> >>> actually do take care of gating the clocks via the interconnect
> >>> level code that is hwmod in this case.
> >> I removed all PM runtime calls that revolved around
> >> pwmss_submodule_state_change. Originally the driver would do
> >> a pm_runtime_get_sync then call pwmss_submodule_state_change
> >> and then immediately call pm_runtime_put_sync. Without
> >> pwmss_submodule_state_change those calls would be
> >> meaningless.  I also removed pm_runtime calls in error paths
> >> that no longer existed.
> > Typically the interconnect level code can gate the clkctrl bit
> > for the module with PM runtime even with no other driver specific
> > registers. If you remove the pm_runtime calls, that does not
> > happen.
> 
> So the clocks should be unlocked when ever the IP registers are
> being read/written or if the peripheral is being used for
> example
> the pwm signal is being generated. All these cases are already
> being handled.
> 
> Using ecap driver as an example.
> 
> Pm_runtime_get_sync is called within ecap_pwm_enable when
> the pwm signal is to be generated. Pm_runtime_put_sync is called
> when the pwm signal is to be stopped.
> 
> When either the pwm signal polarity is set or pwm
> configuration is made
> then a pm_runtime_get_sync and pm_runtime_put_sync are
> called within
> the same function surrounding calls to the IP's registers.
> 
> Probe is calling pm_runtime_enable while remove is calling
> pm_runtime_disable.

OK good to hear you have considered this. The above answers
my questions then thanks.

> So the correct pm_runtime calls are being made from what I
> can see.
> I'm not sure I understand the concern since removing those
> calls aren't
> creating any kind of imbalance.

OK thanks for checking.

> If I'm not addressing your concern please give me an example
> of where
> you see a possible issue.

No that's fine. I thought you're ripping out all of the the
pm_runtime based on just looking at the patch :)

> > Also, how do you know this change does not affect the other
> > SoC variants using the same driver?
> 
> I've tested these changes on AM335x GP and AM437x GP evms.
> AM335x
> and AM437x were the only other users of this driver. Sorry 
> I should of
> documented this in my cover-letter.

OK good to hear.

Thanks,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
  [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
    Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
      Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tero Kristo <t-kristo@ti.com> - 2016-03-01 14:00 +0100
        Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:10 +0100
  [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
    Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 19:10 +0100
    Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:20 +0100
      Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 20:00 +0100
        Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:00 +0100
          Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 17:30 +0100
            Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 03:10 +0100
              Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-04 07:30 +0100
  [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
    Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
      Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
  [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
    Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
      Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-26 20:50 +0100
    Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
      Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:10 +0100
    Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Rob Herring <robh@kernel.org> - 2016-03-02 19:30 +0100
      Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 02:50 +0100
  [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
    Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Sekhar Nori <nsekhar@ti.com> - 2016-02-26 11:30 +0100
      Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
    Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Tony Lindgren <tony@atomide.com> - 2016-02-29 23:10 +0100
      Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-02-29 23:40 +0100
        Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:00 +0100
          Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-01 00:20 +0100
            Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
              Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 20:50 +0100
                Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock  gating Tony Lindgren <tony@atomide.com> - 2016-03-03 00:00 +0100

csiph-web