Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346596
| From | Tero Kristo <t-kristo@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS |
| Date | 2016-03-01 14:00 +0100 |
| Message-ID | <r7S4b-Pg-45@gated-at.bofh.it> (permalink) |
| References | <r6cJH-27E-1@gated-at.bofh.it> <r6cJI-27E-3@gated-at.bofh.it> <r7Fqi-18H-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/01/2016 01:23 AM, Tony Lindgren wrote:
> * Franklin S Cooper Jr <fcooper@ti.com> [160225 14:37]:
>> From: Vignesh R <vigneshr@ti.com>
>>
>> tbclk is used by ehrpwm to generate PWM waveform on DRA7 SoC. Add Linux
>> clock to control ehrpwm tbclk.
>> The TRM says, tbclk is derived from SYSCLKOUT. SYSCLKOUT is nothing but
>> ehrpwm functional clock derived from the gateable interface and
>> functional clock of PWMSS(l4_root_clk_div).
>> Refer AM57x TRM SPRUHZ6[1], October 2014, Table 29-4 and Section 29.2.2.1,
>> Table 29-19 and the NOTE at the end of the table.
>>
>> [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf
>
> Applying this into omap-for-v4.6/dt thanks.
>
> Note for Tero, let's plan on getting rid of the duplicate
> reg entries by using the standard clock output offset within
> the clock register. I think we should easily be able to add
> a binding for this and then deprecate the overlapping reg
> entries.
Yeah, we have been discussing this offline a bit, but haven't had time
to look at this. I believe the hwmod clock conversion is of higher
priority still.
-Tero
>
> Regards,
>
> Tony
>
>> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
>> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
>> @@ -2146,4 +2146,28 @@
>> ti,bit-shift = <0>;
>> reg = <0x558>;
>> };
>> +
>> + ehrpwm0_tbclk: ehrpwm0_tbclk {
>> + #clock-cells = <0>;
>> + compatible = "ti,gate-clock";
>> + clocks = <&l4_root_clk_div>;
>> + ti,bit-shift = <20>;
>> + reg = <0x0558>;
>> + };
>> +
>> + ehrpwm1_tbclk: ehrpwm1_tbclk {
>> + #clock-cells = <0>;
>> + compatible = "ti,gate-clock";
>> + clocks = <&l4_root_clk_div>;
>> + ti,bit-shift = <21>;
>> + reg = <0x0558>;
>> + };
>> +
>> + ehrpwm2_tbclk: ehrpwm2_tbclk {
>> + #clock-cells = <0>;
>> + compatible = "ti,gate-clock";
>> + clocks = <&l4_root_clk_div>;
>> + ti,bit-shift = <22>;
>> + reg = <0x0558>;
>> + };
>> };
>> --
>> 2.7.0
>>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
[PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tero Kristo <t-kristo@ti.com> - 2016-03-01 14:00 +0100
Re: [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:10 +0100
[PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 19:10 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 19:20 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-01 20:00 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:00 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 17:30 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 03:10 +0100
Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Paul Walmsley <paul@pwsan.com> - 2016-03-04 07:30 +0100
[PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
[PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-26 20:50 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Tony Lindgren <tony@atomide.com> - 2016-03-01 22:10 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Rob Herring <robh@kernel.org> - 2016-03-02 19:30 +0100
Re: [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-04 02:50 +0100
[PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr <fcooper@ti.com> - 2016-02-25 23:40 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Sekhar Nori <nsekhar@ti.com> - 2016-02-26 11:30 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-02-26 20:20 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-02-29 23:10 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-02-29 23:40 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:00 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-01 00:20 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-01 00:30 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-03-02 20:50 +0100
Re: [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Tony Lindgren <tony@atomide.com> - 2016-03-03 00:00 +0100
csiph-web