Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334165

[PATCH 1/3] drivers/acpi: make bgrt driver explicitly non-modular

Show all headers | View raw

The Kconfig for this driver is currently:

config ACPI_BGRT
    bool "Boottime Graphics Resource Table support"

...meaning that it currently is not being built as a module by anyone.
Lets remove all modular references, so that when reading the driver
there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/acpi/bgrt.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c
index a83e3c62c5a9..75f128e766a9 100644
--- a/drivers/acpi/bgrt.c
+++ b/drivers/acpi/bgrt.c
@@ -1,4 +1,6 @@
 /*
+ * BGRT boot graphic support
+ * Authors: Matthew Garrett, Josh Triplett <josh@joshtriplett.org>
  * Copyright 2012 Red Hat, Inc <mjg@redhat.com>
  * Copyright 2012 Intel Corporation
  *
@@ -8,7 +10,6 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/device.h>
 #include <linux/sysfs.h>
@@ -103,9 +104,4 @@ out_kobject:
 	kobject_put(bgrt_kobj);
 	return ret;
 }
-
-module_init(bgrt_init);
-
-MODULE_AUTHOR("Matthew Garrett, Josh Triplett <josh@joshtriplett.org>");
-MODULE_DESCRIPTION("BGRT boot graphic support");
-MODULE_LICENSE("GPL");
+device_initcall(bgrt_init);
-- 
2.6.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] acpi: remove modular references from non modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
  [PATCH 2/3] drivers/acpi: make apei/ghes.c more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
  [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
    Re: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly  non-modular Aaron Lu <aaron.lu@intel.com> - 2016-02-16 04:00 +0100
    RE: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly  non-modular "Zheng, Lv" <lv.zheng@intel.com> - 2016-02-17 03:30 +0100
  [PATCH 1/3] drivers/acpi: make bgrt driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:40 +0100
  Re: [PATCH 0/3] acpi: remove modular references from non modular code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 20:30 +0100
  RE: [PATCH 0/3] acpi: remove modular references from non modular  code "Zheng, Lv" <lv.zheng@intel.com> - 2016-02-17 03:30 +0100

csiph-web