Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334164

[PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular

Show all headers | View raw

The Kconfig currently controlling compilation of this code is:

drivers/acpi/Kconfig:config CRC_PMIC_OPREGION
drivers/acpi/Kconfig:   bool "ACPI operation region support for CrystalCove PMIC"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple modular references, so that when reading
the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: Aaron Lu <aaron.lu@intel.com>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/acpi/pmic/intel_pmic_crc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/acpi/pmic/intel_pmic_crc.c b/drivers/acpi/pmic/intel_pmic_crc.c
index 42df46a86c25..fcd1852dcdee 100644
--- a/drivers/acpi/pmic/intel_pmic_crc.c
+++ b/drivers/acpi/pmic/intel_pmic_crc.c
@@ -13,7 +13,7 @@
  * GNU General Public License for more details.
  */
 
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/acpi.h>
 #include <linux/mfd/intel_soc_pmic.h>
 #include <linux/regmap.h>
@@ -205,7 +205,4 @@ static int __init intel_crc_pmic_opregion_driver_init(void)
 {
 	return platform_driver_register(&intel_crc_pmic_opregion_driver);
 }
-module_init(intel_crc_pmic_opregion_driver_init);
-
-MODULE_DESCRIPTION("CrystalCove ACPI operation region driver");
-MODULE_LICENSE("GPL");
+device_initcall(intel_crc_pmic_opregion_driver_init);
-- 
2.6.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] acpi: remove modular references from non modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
  [PATCH 2/3] drivers/acpi: make apei/ghes.c more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
  [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:30 +0100
    Re: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly  non-modular Aaron Lu <aaron.lu@intel.com> - 2016-02-16 04:00 +0100
    RE: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly  non-modular "Zheng, Lv" <lv.zheng@intel.com> - 2016-02-17 03:30 +0100
  [PATCH 1/3] drivers/acpi: make bgrt driver explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-15 06:40 +0100
  Re: [PATCH 0/3] acpi: remove modular references from non modular code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-16 20:30 +0100
  RE: [PATCH 0/3] acpi: remove modular references from non modular  code "Zheng, Lv" <lv.zheng@intel.com> - 2016-02-17 03:30 +0100

csiph-web