Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332143
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check |
| Date | 2016-02-11 16:20 +0100 |
| Message-ID | <r11cf-26P-29@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on
paravirt") added a paravirt test in microcode_init(), primarily to avoid
making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls
On 32-bit kernels this callchain ends up using __pa_nodebug() macro
which is invalid for Xen PV guests.
A subsequent commit, fbae4ba8c4a3 ("x86, microcode: Reload microcode on
resume"), eliminated this callchain thus making a18a0f6850d4
unnecessary.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
arch/x86/kernel/cpu/microcode/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index cea8552..ac360bf 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -623,7 +623,7 @@ int __init microcode_init(void)
struct cpuinfo_x86 *c = &boot_cpu_data;
int error;
- if (paravirt_enabled() || dis_ucode_ldr)
+ if (dis_ucode_ldr)
return -EINVAL;
if (c->x86_vendor == X86_VENDOR_INTEL)
--
2.1.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-11 16:20 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-11 19:20 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 11:10 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 11:20 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 11:40 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 11:50 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:00 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:10 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 12:20 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:30 +0100
Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 12:40 +0100
csiph-web