[PATCH] x86, microcode: Remove unnecessary paravirt_enabled check

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] x86, microcode: Remove unnecessary paravirt_enabled check
Date	Thu, 11 Feb 2016 16:20:03 +0100
Message-ID	<r11cf-26P-29@gated-at.bofh.it> (permalink)
X-Original-To	bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
X-Mailer	git-send-email 2.1.0
X-Source-IP	userv0021.oracle.com [156.151.31.71]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	x86@kernel.org, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
X-Original-Date	Thu, 11 Feb 2016 10:13:18 -0500
X-Original-Message-ID	<1455203598-14378-1-git-send-email-boris.ostrovsky@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1332143

Show key headers only | View raw

Commit a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on
paravirt") added a paravirt test in microcode_init(), primarily to avoid
making mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls
On 32-bit kernels this callchain ends up using __pa_nodebug() macro
which is invalid for Xen PV guests.

A subsequent commit, fbae4ba8c4a3 ("x86, microcode: Reload microcode on
resume"), eliminated this callchain thus making a18a0f6850d4
unnecessary.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/kernel/cpu/microcode/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index cea8552..ac360bf 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -623,7 +623,7 @@ int __init microcode_init(void)
 	struct cpuinfo_x86 *c = &boot_cpu_data;
 	int error;
 
-	if (paravirt_enabled() || dis_ucode_ldr)
+	if (dis_ucode_ldr)
 		return -EINVAL;
 
 	if (c->x86_vendor == X86_VENDOR_INTEL)
-- 
2.1.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-11 16:20 +0100
  Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-11 19:20 +0100
  Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 11:10 +0100
    Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 11:20 +0100
      Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 11:40 +0100
        Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 11:50 +0100
          Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:00 +0100
            Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:10 +0100
              Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 12:20 +0100
                Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-19 12:30 +0100
                Re: [PATCH] x86, microcode: Remove unnecessary paravirt_enabled check Borislav Petkov <bp@alien8.de> - 2016-02-19 12:40 +0100

csiph-web