Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64
Date	2016-02-11 16:00 +0100
Message-ID	<r10SS-1KU-9@gated-at.bofh.it> (permalink)
References	<r0uJk-5La-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Wed, 10 Feb 2016 10:08:54 +0530

> 32 bit systems using 'struct timeval' will break in the year 2038, so
> we replace the code appropriately. However, this driver is not broken
> in 2038 since we are only using microseconds portion of the time.
> 
> This patch replaces 'struct timeval' with 'struct timespec64'. We only
> need to find elapsed microseconds rather than absolute time, so it's
> better to use monotonic time, so using ktime_get_ts64() makes the code
> more efficient and more robust against concurrent settimeofday()
> calls.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with  timespec64 Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-10 05:40 +0100
  Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with  timespec64 Thomas Sailer <t.sailer@alumni.ethz.ch> - 2016-02-10 12:10 +0100
  Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with  timespec64 David Miller <davem@davemloft.net> - 2016-02-11 16:00 +0100

csiph-web