Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1330004

Re: [PATCH v3 0/2] Consolidate redundant register/stack access code

Show all headers | View raw

* Michael Ellerman <mpe@ellerman.id.au> wrote:

> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
> 
> > From: "David A. Long" <dave.long@linaro.org>
> >
> > Move duplicate and functionally equivalent code for accessing registers
> > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
> > common kernel files.
> >
> > I'm sending this out again (with updated distribution list) because v2
> > just never got pulled in, even though I don't think there were any
> > outstanding issues.
> 
> A big cross arch patch like this would often get taken by Andrew Morton, but
> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
> us :D

The other problem is that the second patch is commingling changes to 6 separate 
architectures:

 16 files changed, 106 insertions(+), 343 deletions(-)

that should probably be 6 separate patches. Easier to review, easier to bisect to, 
easier to revert, etc.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  [PATCH v3 1/2] Move the pt_regs_offset struct definition from arch to common include file David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  [PATCH v3 2/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Michael Ellerman <mpe@ellerman.id.au> - 2016-02-09 10:40 +0100
    Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Ingo Molnar <mingo@kernel.org> - 2016-02-09 10:50 +0100
      Re: [PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 22:00 +0100
        Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Ingo Molnar <mingo@kernel.org> - 2016-02-17 10:50 +0100
    Re: [PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 22:00 +0100

csiph-web