Re: [PATCH v3 0/2] Consolidate redundant register/stack access code

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/2] Consolidate redundant register/stack access code
Date	Tue, 09 Feb 2016 10:50:02 +0100
Message-ID	<r0d5M-2cL-7@gated-at.bofh.it> (permalink)
References	<r09bP-85n-1@gated-at.bofh.it> <r0cW6-28I-19@gated-at.bofh.it>
X-Original-To	Michael Ellerman <mpe@ellerman.id.au>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=raMgzhi7/UFAUTHc1SVMQOb0g4ha9BlnNq/mqYh7Y5w=; b=QJO5KCsUqjygViZBZSEfMIGW4Kqf1txhT2KUMbzxVgMVc7THCv2XnJ1WBlwqMRSwJi uCuFscGfvFxmhbPoyNKd9ngce99sDFMmlr8k7lMcYx/gHJQMjWki3fme3bDOLKRR5r+x MQcFuQmdiuuRBVWSbJtJ1ky0uJBKFh2VJqBrez8VYv8ApLFXYwqbMufq4vJj+4LYiz9R wU4kyv15mAnPkldNSE2vwcOkPE4oq6q7t3rhaKzEnpzC15y6wyTJy4M9xUiN7YXBJOvS 7tcyoto7jILby9j6VKsFNbCeCSuTZga/hBPPI8HquMqWYFHeXgLwn3rvLnobKnhiFFSb cymw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=raMgzhi7/UFAUTHc1SVMQOb0g4ha9BlnNq/mqYh7Y5w=; b=YpV9GYre0UTCp7tVmcdqhEeNK9fm9Xvzy9BD0yQG3gjsBPruwdUxwe+vyrJ5/9J/q1 wl8gpVmZFU+gSQZzuKNgb8NpEt3AngqwRpH+AyB0dOJZRIWjy/ilS4BOM+bTdSBGbuIm QfksCnVBBrQYELYxrYg8DJWh0qpT5JPrZ7HsLoc+3tXidW3VxErWIrTw/UucPl8YS9y9 Y7RLmZT3Fl9Q9H85ySa10s6WuaJjZs1zRRNV6m0UOTdy6U0xKMU0vdO8H5/oS9qX79Sy t9KNMcBUggB/RfIy0vXBFuzEHebUeiV773vAnOaGqhfsNvsqky6t5imXZNUaeWDoTmHW 87BA==
X-Gm-Message-State	AG10YOS0tXRqjlT9+cdkklg7YX8y0PkdNtk2YQFKQ5c8F8VuIZxV5ro8nNr009KU/Qu5kg==
X-Received	by 10.194.9.42 with SMTP id w10mr32089697wja.159.1455011130245; Tue, 09 Feb 2016 01:45:30 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, David Long <dave.long@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>, "chengang@emindsoft.com.cn" <chengang@emindsoft.com.cn>, Andy Lutomirski <luto@kernel.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Borislav Petkov <bp@suse.de>, Brian Gerst <brgerst@gmail.com>, David Hildenbrand <dahi@linux.vnet.ibm.com>, Denys Vlasenko <dvlasenk@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Hendrik Brueckner <brueckner@linux.vnet.ibm.com>, Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>, Kees Cook <keescook@chromium.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Oleg Nesterov <oleg@redhat.com>, Paul Mackerras <paulus@samba.org>, Rashmica Gupta <rashmicy@gmail.com>, Rich Felker <dalias@libc.org>, Richard Kuo <rkuo@codeaurora.org>, Roland McGrath <roland@hack.frob.com>, Russell King <linux@arm.linux.org.uk>, Thomas Gleixner <tglx@linutronix.de>, Will Deacon <will.deacon@arm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org
X-Original-Date	Tue, 9 Feb 2016 10:45:26 +0100
X-Original-Message-ID	<20160209094526.GB25268@gmail.com>
X-Original-References	<1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1330004

Show key headers only | View raw

* Michael Ellerman <mpe@ellerman.id.au> wrote:

> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
> 
> > From: "David A. Long" <dave.long@linaro.org>
> >
> > Move duplicate and functionally equivalent code for accessing registers
> > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
> > common kernel files.
> >
> > I'm sending this out again (with updated distribution list) because v2
> > just never got pulled in, even though I don't think there were any
> > outstanding issues.
> 
> A big cross arch patch like this would often get taken by Andrew Morton, but
> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
> us :D

The other problem is that the second patch is commingling changes to 6 separate 
architectures:

 16 files changed, 106 insertions(+), 343 deletions(-)

that should probably be 6 separate patches. Easier to review, easier to bisect to, 
easier to revert, etc.

Thanks,

	Ingo

Thread

[PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  [PATCH v3 1/2] Move the pt_regs_offset struct definition from arch to common include file David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  [PATCH v3 2/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 06:40 +0100
  Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Michael Ellerman <mpe@ellerman.id.au> - 2016-02-09 10:40 +0100
    Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Ingo Molnar <mingo@kernel.org> - 2016-02-09 10:50 +0100
      Re: [PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 22:00 +0100
        Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Ingo Molnar <mingo@kernel.org> - 2016-02-17 10:50 +0100
    Re: [PATCH v3 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2016-02-09 22:00 +0100

csiph-web