Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331721
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface |
| Date | 2016-02-11 09:20 +0100 |
| Message-ID | <r0UDL-692-1@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <r0BB8-1J1-19@gated-at.bofh.it> <r0DMC-3gn-9@gated-at.bofh.it> <r0DWi-3jE-15@gated-at.bofh.it> <r0EIH-3QV-27@gated-at.bofh.it> <r0UDL-692-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
---------- Forwarded message ----------
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, Feb 11, 2016 at 10:10 AM
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System
Software Interface
To: Oliver Neukum <oneukum@suse.de>
On Wed, Feb 10, 2016 at 5:08 PM, Oliver Neukum <oneukum@suse.de> wrote:
> On Wed, 2016-02-10 at 16:24 +0200, Andy Shevchenko wrote:
>> On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum <oneukum@suse.com> wrote:
>> > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
>> >> > +err:
>> >> > + if (i > 0)
>> >> > + for (; i >= 0; i--, con--)
>> >> > + typec_unregister_port(con->port);
>> >>
>> >> Perhaps
>> >>
>> >> while (--i >= 0) {
>> >> ...
>> >> }
>> >
>> > While we are at it. No we should not change the semantics
>> > of conditionals for the sake of appearance.
>>
>> I'm sorry I didn't get you.
>> How this more or less standard pattern to clean up stuff on error path
>> does with conditional semantics?
>
> You change a postdecrement to a predecrement. The highest
> number the loop is executed for is changed.
I still didn't get.
Variable i is just counter here,
And it seems there is a bug, since when i == 1, we will have
i = 1, con == connector[0]:
typec_unregister_port(con->port);
i = 0, con == connector[1]:
typec_unregister_port(con->port); <<< It wasn't registered yet!
The correct code should be something like
if (i > 0)
for (--i; i >= 0; i--) {}
Which
a) makes conditional redundant;
b) classical pattern of while (--i >= 0) {}
So where am I wrong?
--
With Best Regards,
Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
[PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Greg KH <gregkh@linuxfoundation.org> - 2016-02-09 19:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Greg KH <gregkh@linuxfoundation.org> - 2016-02-10 18:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-15 16:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-16 10:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-16 14:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 09:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 10:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-17 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 12:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbi@kernel.org> - 2016-02-17 14:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 15:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Peter Chen <hzpeterchen@gmail.com> - 2016-02-18 10:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Rajaram R <rajaram.officemail@gmail.com> - 2016-02-18 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Rajaram R <rajaram.officemail@gmail.com> - 2016-02-18 12:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbi@kernel.org> - 2016-02-17 14:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 15:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-18 08:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 11:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-18 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Peter Chen <hzpeterchen@gmail.com> - 2016-02-18 10:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 10:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 12:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 13:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 13:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 14:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 15:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Bjørn Mork <bjorn@mork.no> - 2016-02-10 16:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-11 09:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Bjørn Mork <bjorn@mork.no> - 2016-02-11 10:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 15:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 15:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.de> - 2016-02-10 16:20 +0100
Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-11 09:20 +0100
Re: Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 14:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:10 +0100
[PATCH 3/3] usb: type-c: UCSI ACPI driver Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-09 19:30 +0100
Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 11:30 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Oliver Neukum <oneukum@suse.com> - 2016-02-17 20:00 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 10:30 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Rajaram R <rajaram.officemail@gmail.com> - 2016-02-17 20:40 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 12:10 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Oliver Neukum <oneukum@suse.com> - 2016-02-18 12:20 +0100
csiph-web