Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331750
| From | Bjørn Mork <bjorn@mork.no> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface |
| Date | 2016-02-11 10:10 +0100 |
| Message-ID | <r0Vqa-6Fe-9@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <r0BB8-1J1-19@gated-at.bofh.it> <r0D0f-2IY-17@gated-at.bofh.it> <r0DCV-3cV-3@gated-at.bofh.it> <r0EIH-3QV-31@gated-at.bofh.it> <r0UNr-6c7-1@gated-at.bofh.it> |
| Organization | m |
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> To me out: sounds out, like printing error and return code, or
> something like that. Here the case is different.
>
> And since we have two full switches it might be hard to have on one
> screen out code and exact goto. See my point now?
No, sorry. Not really.
The pattern
out:
return whatever;
is so common in the kernel that I cannot see any point starting a
discussion about it:
bjorn@nemi:/usr/local/src/git/linux$ git grep -A1 ^out:|grep return|wc -l
3622
And I also fail to see any relation between the explanation you come up
with here and the text in CodingStyle, which was what you initially
referred to. There is no specific interpreation of the label name "out"
there AFAICS.
I apologize if you think I am being an ass now. I am. I'm just too fed
up with coding style arguments with no other reason than a vague pointer
to some document. If you're going to point out coding style problems,
then you could at least make an effort explaining why a style change
improves the code. My bet is that most of the time you'll find that the
comment is unnecessary...
Bjørn
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
[PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Greg KH <gregkh@linuxfoundation.org> - 2016-02-09 19:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Greg KH <gregkh@linuxfoundation.org> - 2016-02-10 18:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-15 16:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-16 10:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-16 14:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 09:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 10:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-17 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 12:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbi@kernel.org> - 2016-02-17 14:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-17 15:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Peter Chen <hzpeterchen@gmail.com> - 2016-02-18 10:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Rajaram R <rajaram.officemail@gmail.com> - 2016-02-18 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Rajaram R <rajaram.officemail@gmail.com> - 2016-02-18 12:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbi@kernel.org> - 2016-02-17 14:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-17 15:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-18 08:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 11:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Felipe Balbi <balbif@gmail.com> - 2016-02-18 11:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 11:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Peter Chen <hzpeterchen@gmail.com> - 2016-02-18 10:40 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-18 10:50 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 12:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 13:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 13:00 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 14:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 15:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Bjørn Mork <bjorn@mork.no> - 2016-02-10 16:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-11 09:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Bjørn Mork <bjorn@mork.no> - 2016-02-11 10:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 15:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-10 15:30 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.de> - 2016-02-10 16:20 +0100
Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-11 09:20 +0100
Re: Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:20 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Oliver Neukum <oneukum@suse.com> - 2016-02-10 14:10 +0100
Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-11 15:10 +0100
[PATCH 3/3] usb: type-c: UCSI ACPI driver Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-09 18:10 +0100
Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-09 19:30 +0100
Re: [PATCH 3/3] usb: type-c: UCSI ACPI driver Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-10 11:30 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Oliver Neukum <oneukum@suse.com> - 2016-02-17 20:00 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 10:30 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Rajaram R <rajaram.officemail@gmail.com> - 2016-02-17 20:40 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-18 12:10 +0100
Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI Oliver Neukum <oneukum@suse.com> - 2016-02-18 12:20 +0100
csiph-web