Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support
Date	2015-11-27 22:20 +0100
Message-ID	<qzyAV-85W-7@gated-at.bofh.it> (permalink)
References	<qzva1-5TV-3@gated-at.bofh.it> <qzxOy-7zb-11@gated-at.bofh.it> <qzyhA-7Kz-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday 27 November 2015 12:56:05 Ray Jui wrote:
> >
> > You seem to only need the identifiers in order to set a single
> > pointer, so just point to that array directly.
> 
> Not just a single pointer. This sets the iProc PCIe interface type, 
> which is an enum. Based on the interface type, both the iProc PCIe core 
> driver and the iProc PCIe MSI driver can 1) load the correct set of 
> register offsets; 2) skip/invoke some of the link detection, controller 
> reset related behaviors; 3) setting up the correct number of MSI event 
> queue regions and MSI address regions.

Ok, fair enough. I had missed 2) and 3) here. It could still be done
as a structure (rather than function pointers) with individual named
members for each register offset along with bool flags for 2) and
integers to describe 3).

Please that suggestion some thought, and then decide for yourself,
I won't complain if you keep the current version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 18:40 +0100
  Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Arnd Bergmann <arnd@arndb.de> - 2015-11-27 21:30 +0100
    Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 22:00 +0100
      Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 22:20 +0100
      Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Arnd Bergmann <arnd@arndb.de> - 2015-11-27 22:20 +0100

csiph-web