Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support
Date	Fri, 27 Nov 2015 22:20:02 +0100
Message-ID	<qzyAV-85W-7@gated-at.bofh.it> (permalink)
References	<qzva1-5TV-3@gated-at.bofh.it> <qzxOy-7zb-11@gated-at.bofh.it> <qzyhA-7Kz-27@gated-at.bofh.it>
X-Original-To	Ray Jui <rjui@broadcom.com>
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:/GXpoA3rrmZ7HlwdY8OJDzGanUK07HddL7uiU9NtLXPId+QmHYX L7LyKN7cbRfRquIxWYHqvw3zdJs4NOu3lqRhIM3ksc1ByaFClYgkdbIQNRt282s8c0RwVAl b+/Vo0Owmj+2Y4Tx/dst/ujrCFmqjKqTYcYc0E/s6180+nT1msAgpm3ISaChb0mwlURRo0M amLcQykJaYfuqSHVIlaNQ==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:Xe9TwOchccU=:PydnuFBR/eiFNaY5w4UJ6t HxNXDyAwvNYG5YhWyjSqHUkSWvLQhAFu1yIsLrl8OnCuLq2v25GUvqvKOeRb1zrIi1GoPkmcI qou2vc4OhQnTbZ0gWjvEWZv9+3wFzvI6twydwXsz97GHWVIYwl6iz3XfgxCo/fze5d1hpLj9t X3Q4lLeGcrFXNJ8fuLbGjnk0n54hVq6I8m0RFhLf8yvtfwyKgWZPCcD1DJrx/W6/Fp5err0Pw E5gUL5NMX/DqFkb7Q80cE61OkV+sY5nffMz4a/xZC+Pynts8lOfJh9ldIPEZujsxHfUSM5P7O UnRkAX0az1KsbHo2l/Sjo+rWABDti1jNcNWdpZCTFBYWBJZrr0+m8dnAVSWidm3ZXuRjpzHdF ifCDyc51C1pYHaCb0zbkrbXmy3vXgKzg4Pbqh7DjpKAUE82nKovs1uvHRAwUR36ofDNHnzRmj uH6hUtvMpztQx8V3a43BczyKu+UYJPpHivhrT39TA/LaaxALwlhFOk6Kx1K8k1zAvu+M5/z9c yLuSiFyIn+sRIMIOeNmd/ZQyyZYJp30+y8g/iMJvDZDpOmiyoAtdXkO2rEkFYkuKMLLlh1PJA wCVgyfZy2guS0j1b6YenBibe7DxeBNXTbu2prINDcX37gq6kWIXF+XYGiYw7XS1AUVipe/RqF +6ZsuBbJbyOhXGVrd80qPkD4B6vtbjUjE7DgxBE5qLYW+BB18PkpF6JtHWiImngKmsEiYE34Y q1DKM2XQiK43ay5I
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	Bjorn Helgaas <bhelgaas@google.com>, Marc Zyngier <marc.zyngier@arm.com>, Hauke Mehrtens <hauke@hauke-m.de>, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org
X-Original-Date	Fri, 27 Nov 2015 22:11:15 +0100
X-Original-Message-ID	<3529525.ts0Jjxrtm5@wuerfel>
X-Original-References	<1448645868-5730-1-git-send-email-rjui@broadcom.com> <2502233.oJMLi3GpfH@wuerfel> <5658C365.5080209@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1278978

Show key headers only | View raw

On Friday 27 November 2015 12:56:05 Ray Jui wrote:
> >
> > You seem to only need the identifiers in order to set a single
> > pointer, so just point to that array directly.
> 
> Not just a single pointer. This sets the iProc PCIe interface type, 
> which is an enum. Based on the interface type, both the iProc PCIe core 
> driver and the iProc PCIe MSI driver can 1) load the correct set of 
> register offsets; 2) skip/invoke some of the link detection, controller 
> reset related behaviors; 3) setting up the correct number of MSI event 
> queue regions and MSI address regions.

Ok, fair enough. I had missed 2) and 3) here. It could still be done
as a structure (rather than function pointers) with individual named
members for each register offset along with bool flags for 2) and
integers to describe 3).

Please that suggestion some thought, and then decide for yourself,
I won't complain if you keep the current version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 18:40 +0100
  Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Arnd Bergmann <arnd@arndb.de> - 2015-11-27 21:30 +0100
    Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 22:00 +0100
      Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Ray Jui <rjui@broadcom.com> - 2015-11-27 22:20 +0100
      Re: [PATCH v4 2/5] PCI: iproc: Add PAXC interface support Arnd Bergmann <arnd@arndb.de> - 2015-11-27 22:20 +0100

csiph-web