Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC
Date	2015-11-17 10:20 +0100
Message-ID	<qvKAF-355-1@gated-at.bofh.it> (permalink)
References	<qr9T3-3m9-3@gated-at.bofh.it> <qr9T4-3m9-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <afd@ti.com> wrote:

> Add support for the TPS65086 PMIC GPOs.
>
> TPS65086 has four configurable GPOs that can be used for several
> purposes.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

OK...

> +static int tps65086_gpio_get(struct gpio_chip *gc, unsigned offset)
> +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset,

Just get/set and no get_direction/direction_input/direction_output?
Are you sure?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 10:20 +0100
  Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-17 17:20 +0100
    Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-11-18 10:50 +0100
      Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-18 17:50 +0100

csiph-web