Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC
Date	Tue, 17 Nov 2015 10:20:01 +0100
Message-ID	<qvKAF-355-1@gated-at.bofh.it> (permalink)
References	<qr9T3-3m9-3@gated-at.bofh.it> <qr9T4-3m9-31@gated-at.bofh.it>
X-Original-To	"Andrew F. Davis" <afd@ti.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nsNBJ9XxHmfg+n6kT/I6kSByPwayvD3d14SKazhiNNw=; b=ocvGQtXd+V+feRAVt27HXFNGoc5W48c6CmCB931N4PV1DrO0aW0z1TiDdA90uG3kg9 9U1GEz2id9gzE7m8oN5zxmxlVH0m9oVGpa55v68RJwt2pogOmE39dLSSt+cQvhSUDkOa bwSo+4T81H9HGziBR5ApxhBLlwxmBYlQCmeMvjvYAhCA7fXoHq5NxvCTI8bnndP2sJjx pOa9CSdpGFgyWXw+18irxEy8TS9mQNXoCsaUfDDVO0FnvNGs2LMgeN5P/2q3fWK7t38Z wmJoc2RXtF0U/9dk7xmKWjyaAmDbeONQ/OAV36LpsybxRCNr5KkxpmYi29fj+/VSVHdI WamQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nsNBJ9XxHmfg+n6kT/I6kSByPwayvD3d14SKazhiNNw=; b=YUcWXDqbO1RlQXrTNwJQJN3V6eBv+bA1arELZyxBlfh4TCjgpn8Z6c92+JePYUFDoO gExiFaEVx73wzYy0tEBcAczqK9mUMOh+qyKiv6OYab+T4M7pOQqzgUXFubS+aR+D+nb0 IxTTyBqeHoRIME5ijsDa1YgoK2PO59CKfIa2mf1o8WXYq+Nn1QA+g7x3sB7++CAxpV0x UiRVvlzVvSs27k11WSe0DoKo2r6PNp4iYNIbcaxwKjWlFtDZ9ZdDoOpKzlfFaity8xpU i5Y7ku2w18ouuVNfNJglhSsD4eDyMwq2tegcdsMd8CQLRMQfhNXHiAS3dzUS+DOrY8za QNRg==
X-Gm-Message-State	ALoCoQmHPzXUsBtUPjLxMnZYJe6zpVaFdbLYC8O000QilBTItpOg/EukJODlptwxzRNJh9DZIUAb
MIME-Version	1.0
X-Received	by 10.202.65.11 with SMTP id o11mr23873267oia.39.1447751853794; Tue, 17 Nov 2015 01:17:33 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alexandre Courbot <gnurou@gmail.com>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 17 Nov 2015 10:17:33 +0100
X-Original-Message-ID	<CACRpkdb1V7JxLSbwqf4CX+nDLeQzP=bOA9YMXzE4CFTQfzRL9w@mail.gmail.com>
X-Original-References	<1446657135-7820-1-git-send-email-afd@ti.com> <1446657135-7820-7-git-send-email-afd@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1270986

Show key headers only | View raw

On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <afd@ti.com> wrote:

> Add support for the TPS65086 PMIC GPOs.
>
> TPS65086 has four configurable GPOs that can be used for several
> purposes.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

OK...

> +static int tps65086_gpio_get(struct gpio_chip *gc, unsigned offset)
> +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset,

Just get/set and no get_direction/direction_input/direction_output?
Are you sure?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 10:20 +0100
  Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-17 17:20 +0100
    Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-11-18 10:50 +0100
      Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-18 17:50 +0100

csiph-web