Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266505

Re: [DRBD-user] [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

Show all headers | View raw

On Mon, Nov 09, 2015 at 08:56:10PM +0900, Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.

For the DRBD part:

>  drivers/block/drbd/drbd_bitmap.c                   | 26 +++++------------
>  drivers/block/drbd/drbd_int.h                      |  3 --

> diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
> index 9462d27..2daaafb 100644
> --- a/drivers/block/drbd/drbd_bitmap.c
> +++ b/drivers/block/drbd/drbd_bitmap.c
> @@ -364,12 +364,9 @@ static void bm_free_pages(struct page **pages, unsigned long number)
>  	}
>  }
>  
> -static void bm_vk_free(void *ptr, int v)
> +static inline void bm_vk_free(void *ptr)

Maybe drop this inline completely ...

>  {
> -	if (v)
> -		vfree(ptr);
> -	else
> -		kfree(ptr);
> +	kvfree(ptr);
>  }

... and just call kvfree() directly below?

> -				bm_vk_free(new_pages, vmalloced);
> +				bm_vk_free(new_pages);

  +				kvfree(new_pages);
  ...


Other than that: looks good and harmless enough.
Thanks,

	Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-11-09 13:00 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Jan Kara <jack@suse.cz> - 2015-11-09 13:20 +0100
    Re: [PATCH] tree wide: Use kvfree() than conditional  kfree()/vfree() David Miller <davem@davemloft.net> - 2015-11-09 17:30 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-09 17:10 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Dilger, Andreas" <andreas.dilger@intel.com> - 2015-11-09 21:50 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-09 22:20 +0100
    RE: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Luck, Tony" <tony.luck@intel.com> - 2015-11-10 00:30 +0100
  Re: [DRBD-user] [PATCH] tree wide: Use kvfree() than conditional  kfree()/vfree() Lars Ellenberg <lars.ellenberg@linbit.com> - 2015-11-10 14:40 +0100

csiph-web