Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265780

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

Show all headers | View raw

On Mon, Nov 09, 2015 at 08:56:10PM +0900, Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Cc: Russell King <linux@arm.linux.org.uk> # arm

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

In so far as this ARM specific change looks reasonable.  Thanks.

> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index e62400e..492bf3e 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -1200,10 +1200,7 @@ error:
>  	while (i--)
>  		if (pages[i])
>  			__free_pages(pages[i], 0);
> -	if (array_size <= PAGE_SIZE)
> -		kfree(pages);
> -	else
> -		vfree(pages);
> +	kvfree(pages);
>  	return NULL;
>  }
>  
> @@ -1211,7 +1208,6 @@ static int __iommu_free_buffer(struct device *dev, struct page **pages,
>  			       size_t size, struct dma_attrs *attrs)
>  {
>  	int count = size >> PAGE_SHIFT;
> -	int array_size = count * sizeof(struct page *);
>  	int i;
>  
>  	if (dma_get_attr(DMA_ATTR_FORCE_CONTIGUOUS, attrs)) {
> @@ -1222,10 +1218,7 @@ static int __iommu_free_buffer(struct device *dev, struct page **pages,
>  				__free_pages(pages[i], 0);
>  	}
>  
> -	if (array_size <= PAGE_SIZE)
> -		kfree(pages);
> -	else
> -		vfree(pages);
> +	kvfree(pages);
>  	return 0;
>  }
>  

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2015-11-09 13:00 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Jan Kara <jack@suse.cz> - 2015-11-09 13:20 +0100
    Re: [PATCH] tree wide: Use kvfree() than conditional  kfree()/vfree() David Miller <davem@davemloft.net> - 2015-11-09 17:30 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-09 17:10 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Dilger, Andreas" <andreas.dilger@intel.com> - 2015-11-09 21:50 +0100
  Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-09 22:20 +0100
    RE: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() "Luck, Tony" <tony.luck@intel.com> - 2015-11-10 00:30 +0100
  Re: [DRBD-user] [PATCH] tree wide: Use kvfree() than conditional  kfree()/vfree() Lars Ellenberg <lars.ellenberg@linbit.com> - 2015-11-10 14:40 +0100

csiph-web