RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

From	Madalin-Cristian Bucur <madalin.bucur@freescale.com>
Newsgroups	linux.kernel
Subject	RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Date	2015-11-03 10:50 +0100
Message-ID	<qqGo2-WT-19@gated-at.bofh.it> (permalink)
References	<qqtqO-10k-9@gated-at.bofh.it> <qqtqO-10k-11@gated-at.bofh.it> <qqEYV-9k-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> 
> On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > +               if (net_ratelimit())
> > +                       netif_warn(priv, hw, net_dev, "FD status =
> 0x%08x\n",
> > +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> > +
> > +               percpu_stats->rx_errors++;
> > +               goto _release_frame;
> > +       }
> 
> I cannot find any detailed error accounting(maybe I am not looking hard
> enough) but I
> would appreciate if both TX and RX errors where better
> accounted(rx_length_errors, rx_frame_errors,
> rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the
> past diagnosing
> board HW problems.
> 
>  Jocke

Hi Jocke,

There are some error counters exported through ethtool (used to be debugfs).
FMan HW provides more debug information than we currently export, that will be
improved in the future but given the current priority of having a codebase as
small and reviewable as possible we had to drop some things from the initial
submission.

Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Joakim Tjernlund <joakim.tjernlund@transmode.se> - 2015-11-03 09:20 +0100
  RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-11-03 10:50 +0100
    Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Joakim Tjernlund <joakim.tjernlund@transmode.se> - 2015-11-03 12:30 +0100
      RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-11-03 14:30 +0100

csiph-web