Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261267 > unrolled thread

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

Started byJoakim Tjernlund <joakim.tjernlund@transmode.se>
First post2015-11-03 09:20 +0100
Last post2015-11-03 14:30 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Joakim Tjernlund <joakim.tjernlund@transmode.se> - 2015-11-03 09:20 +0100
    RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-11-03 10:50 +0100
      Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Joakim Tjernlund <joakim.tjernlund@transmode.se> - 2015-11-03 12:30 +0100
        RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-11-03 14:30 +0100

#1261267 — Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

FromJoakim Tjernlund <joakim.tjernlund@transmode.se>
Date2015-11-03 09:20 +0100
SubjectRe: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Message-ID<qqEYV-9k-5@gated-at.bofh.it>
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> +               if (net_ratelimit())
> +                       netif_warn(priv, hw, net_dev, "FD status = 0x%08x\n",
> +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> +
> +               percpu_stats->rx_errors++;
> +               goto _release_frame;
> +       }

I cannot find any detailed error accounting(maybe I am not looking hard enough) but I
would appreciate if both TX and RX errors where better accounted(rx_length_errors, rx_frame_errors,
rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the past diagnosing
board HW problems.

 Jocke--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1261341

FromMadalin-Cristian Bucur <madalin.bucur@freescale.com>
Date2015-11-03 10:50 +0100
Message-ID<qqGo2-WT-19@gated-at.bofh.it>
In reply to#1261267
> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> 
> On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > +               if (net_ratelimit())
> > +                       netif_warn(priv, hw, net_dev, "FD status =
> 0x%08x\n",
> > +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> > +
> > +               percpu_stats->rx_errors++;
> > +               goto _release_frame;
> > +       }
> 
> I cannot find any detailed error accounting(maybe I am not looking hard
> enough) but I
> would appreciate if both TX and RX errors where better
> accounted(rx_length_errors, rx_frame_errors,
> rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the
> past diagnosing
> board HW problems.
> 
>  Jocke

Hi Jocke,

There are some error counters exported through ethtool (used to be debugfs).
FMan HW provides more debug information than we currently export, that will be
improved in the future but given the current priority of having a codebase as
small and reviewable as possible we had to drop some things from the initial
submission.

Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261422

FromJoakim Tjernlund <joakim.tjernlund@transmode.se>
Date2015-11-03 12:30 +0100
Message-ID<qqHWN-23s-5@gated-at.bofh.it>
In reply to#1261341
On Tue, 2015-11-03 at 09:37 +0000, Madalin-Cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> > 
> > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > > +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > > +               if (net_ratelimit())
> > > +                       netif_warn(priv, hw, net_dev, "FD status =
> > 0x%08x\n",
> > > +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> > > +
> > > +               percpu_stats->rx_errors++;
> > > +               goto _release_frame;
> > > +       }
> > 
> > I cannot find any detailed error accounting(maybe I am not looking hard
> > enough) but I
> > would appreciate if both TX and RX errors where better
> > accounted(rx_length_errors, rx_frame_errors,
> > rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the
> > past diagnosing
> > board HW problems.
> > 
> >  Jocke
> 
> Hi Jocke,
> 
> There are some error counters exported through ethtool (used to be debugfs).
> FMan HW provides more debug information than we currently export, that will be
> improved in the future but given the current priority of having a codebase as
> small and reviewable as possible we had to drop some things from the initial
> submission.

I know, but ethtool is not always available.
Even the old fec_main.c has it:
 		if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO |
			   BD_ENET_RX_CR | BD_ENET_RX_OV)) {
			ndev->stats.rx_errors++;
			if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH)) {
				/* Frame too long or too short. */
				ndev->stats.rx_length_errors++;
			}
			if (status & BD_ENET_RX_NO)	/* Frame alignment */
				ndev->stats.rx_frame_errors++;
			if (status & BD_ENET_RX_CR)	/* CRC Error */
				ndev->stats.rx_crc_errors++;
			if (status & BD_ENET_RX_OV)	/* FIFO overrun */
				ndev->stats.rx_fifo_errors++;
		}
so it is just a few more lines ... Pretty please ? :)

 Jocke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1261499

FromMadalin-Cristian Bucur <madalin.bucur@freescale.com>
Date2015-11-03 14:30 +0100
Message-ID<qqJOX-3f4-23@gated-at.bofh.it>
In reply to#1261422
> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> 
> On Tue, 2015-11-03 at 09:37 +0000, Madalin-Cristian Bucur wrote:
> > > -----Original Message-----
> > > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> > >
> > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > > > +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > > > +               if (net_ratelimit())
> > > > +                       netif_warn(priv, hw, net_dev, "FD status =
> > > 0x%08x\n",
> > > > +                                  fd_status &
> FM_FD_STAT_RX_ERRORS);
> > > > +
> > > > +               percpu_stats->rx_errors++;
> > > > +               goto _release_frame;
> > > > +       }
> > >
> > > I cannot find any detailed error accounting(maybe I am not looking
> hard
> > > enough) but I
> > > would appreciate if both TX and RX errors where better
> > > accounted(rx_length_errors, rx_frame_errors,
> > > rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in
> the
> > > past diagnosing
> > > board HW problems.
> > >
> > >  Jocke
> >
> > Hi Jocke,
> >
> > There are some error counters exported through ethtool (used to be
> debugfs).
> > FMan HW provides more debug information than we currently export, that
> will be
> > improved in the future but given the current priority of having a
> codebase as
> > small and reviewable as possible we had to drop some things from the
> initial
> > submission.
> 
> I know, but ethtool is not always available.
> Even the old fec_main.c has it:
>  		if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO |
> 			   BD_ENET_RX_CR | BD_ENET_RX_OV)) {
> 			ndev->stats.rx_errors++;
> 			if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH)) {
> 				/* Frame too long or too short. */
> 				ndev->stats.rx_length_errors++;
> 			}
> 			if (status & BD_ENET_RX_NO)	/* Frame alignment */
> 				ndev->stats.rx_frame_errors++;
> 			if (status & BD_ENET_RX_CR)	/* CRC Error */
> 				ndev->stats.rx_crc_errors++;
> 			if (status & BD_ENET_RX_OV)	/* FIFO overrun */
> 				ndev->stats.rx_fifo_errors++;
> 		}
> so it is just a few more lines ... Pretty please ? :)
> 
>  Jocke

It may be more that just a few lines to add complete debug details.
Your request is noted and will be among the first features to work on
after the driver is accepted upstream.

Thanks,
Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web