Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260109
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue |
| Date | 2015-11-01 11:30 +0100 |
| Message-ID | <qpY3D-6YY-7@gated-at.bofh.it> (permalink) |
| References | <qpXAC-6zD-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@gmail.com> wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > #define APCI1032_CTRL_INT_OR (0 << 1) > +#define APCI1032_CTRL_INT_AND BIT(1) And now you have two styles at the same time. I wouldn't change the current definitions. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] comedi: drivers: Fix - BIT macro used coding style issue Ranjith <ranjithece24@gmail.com> - 2015-11-01 11:00 +0100
Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-01 11:30 +0100
Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-01 19:20 +0100
Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-01 19:20 +0100
csiph-web