Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1260107

[PATCH] comedi: drivers: Fix - BIT macro used coding style issue

From Ranjith <ranjithece24@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] comedi: drivers: Fix - BIT macro used coding style issue
Date 2015-11-01 11:00 +0100
Message-ID <qpXAC-6zD-11@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


BIT macro is used for defining bit location instead of shifting
operator -  coding style issue

Signed-off-by: Ranjith T <ranjithece24@gmail.com>
---
 drivers/staging/comedi/drivers/addi_apci_1032.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
index b37166d..fd5ce21 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1032.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
@@ -85,8 +85,8 @@
 #define APCI1032_STATUS_REG		0x0c
 #define APCI1032_CTRL_REG		0x10
 #define APCI1032_CTRL_INT_OR		(0 << 1)
-#define APCI1032_CTRL_INT_AND		(1 << 1)
-#define APCI1032_CTRL_INT_ENA		(1 << 2)
+#define APCI1032_CTRL_INT_AND		BIT(1)
+#define APCI1032_CTRL_INT_ENA		BIT(2)
 
 struct apci1032_private {
 	unsigned long amcc_iobase;	/* base of AMCC I/O registers */
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] comedi: drivers: Fix - BIT macro used coding style issue Ranjith <ranjithece24@gmail.com> - 2015-11-01 11:00 +0100
  Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-01 11:30 +0100
    Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-01 19:20 +0100
      Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-01 19:20 +0100

csiph-web