Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257120

Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sat, Oct 24, 2015 at 01:11:52PM +0100, Adam Sampson wrote:
> The power amplifier for the headphone output is called "the PA" and "the
> headphone amplifier" in Allwinner's documentation for the A10 and A20.
> sun4i-codec calls it "PA" in some places and "Pre-Amplifier" (which
> isn't really accurate) in others, leading to user-visible controls with
> different names referring to the same device.
> 
> When this driver implements audio input, it'll also need to expose
> controls for the line and mic input preamps, so just referring to "the
> Pre-Amplifier" will be ambiguous.
> 
> Change it to use "PA" consistently for the power amplifier.

Just to avoid any ambiguity in the future, could you call that Power
Amp(lifier?) instead?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: sun4i-codec: use consistent names for PA controls Adam Sampson <ats@offog.org> - 2015-10-24 16:00 +0200
  Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-27 19:30 +0100

csiph-web