Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls
Date	Tue, 27 Oct 2015 19:30:01 +0100
Message-ID	<qohap-8R-11@gated-at.bofh.it> (permalink)
References	<qn7wv-25p-25@gated-at.bofh.it>
X-Original-To	Adam Sampson <ats@offog.org>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	60
Organization	linux.* mail to news gateway
X-Original-Cc	lgirdwood@gmail.com, broonie@kernel.org, emilio@elopez.com.ar, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com
X-Original-Date	Tue, 27 Oct 2015 19:27:06 +0100
X-Original-Message-ID	<20151027182706.GE6114@lukather>
X-Original-References	<1445688712-31951-1-git-send-email-ats@offog.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1257120

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sat, Oct 24, 2015 at 01:11:52PM +0100, Adam Sampson wrote:
> The power amplifier for the headphone output is called "the PA" and "the
> headphone amplifier" in Allwinner's documentation for the A10 and A20.
> sun4i-codec calls it "PA" in some places and "Pre-Amplifier" (which
> isn't really accurate) in others, leading to user-visible controls with
> different names referring to the same device.
> 
> When this driver implements audio input, it'll also need to expose
> controls for the line and mic input preamps, so just referring to "the
> Pre-Amplifier" will be ambiguous.
> 
> Change it to use "PA" consistently for the power amplifier.

Just to avoid any ambiguity in the future, could you call that Power
Amp(lifier?) instead?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: sun4i-codec: use consistent names for PA controls Adam Sampson <ats@offog.org> - 2015-10-24 16:00 +0200
  Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-27 19:30 +0100

csiph-web