Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254621
| From | Jarkko Nikula <jarkko.nikula@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports |
| Date | 2015-10-23 16:00 +0200 |
| Message-ID | <qmL2W-3e7-1@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <qmkvM-6IE-51@gated-at.bofh.it> <qmGcW-4Bz-9@gated-at.bofh.it> <qmHC1-6QB-9@gated-at.bofh.it> <qmKqe-2uc-5@gated-at.bofh.it> <qmKTg-32t-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/23/2015 04:40 PM, Mika Westerberg wrote:
> On Fri, Oct 23, 2015 at 04:13:11PM +0300, Mika Westerberg wrote:
>> On Fri, Oct 23, 2015 at 12:16:11PM +0200, Wolfram Sang wrote:
>>> On Fri, Oct 23, 2015 at 11:40:13AM +0300, Mika Westerberg wrote:
>>>> On Thu, Oct 22, 2015 at 02:17:42AM -0700, Dustin Byford wrote:
> Ah, forgot to mention that the i2c-designware-pcidrv.c misses include of
> <linux/acpi.h> so that needs to be fixed. Otherwise we get:
>
> drivers/i2c/busses/i2c-designware-pcidrv.c: In function ‘i2c_dw_pci_probe’:
> drivers/i2c/busses/i2c-designware-pcidrv.c:259:2: error: implicit declaration of function ‘ACPI_COMPANION_SET’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-designware-pcidrv.c:259:33: error: implicit declaration of function ‘ACPI_COMPANION’ [-Werror=implicit-function-declaration]
>
Please also check that patches apply on top of i2c/for-next due recently
applied cleanup patches from me.
I think commit d80d134182ba ("i2c: designware: Move common probe code
into i2c_dw_probe()") makes your patch only a 2 liner to
drivers/i2c/busses/i2c-designware-core.c :-)
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v4 0/2] i2c: acpi: scan ACPI enumerated I2C mux channels Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:20 +0200
[PATCH v4 1/2] acpi: add acpi_preset_companion() stub Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:20 +0200
Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 10:40 +0200
Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub "Rafael J. Wysocki" <rafael@kernel.org> - 2015-10-25 14:50 +0100
Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-25 15:40 +0100
[PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:40 +0200
Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 10:50 +0200
Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Wolfram Sang <wsa@the-dreams.de> - 2015-10-23 12:20 +0200
Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 15:20 +0200
Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 15:50 +0200
Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2015-10-23 16:00 +0200
csiph-web