Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255416

Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub

Show all headers | View raw

On Sunday, October 25, 2015 02:40:10 PM Rafael J. Wysocki wrote:
> On Thu, Oct 22, 2015 at 11:17 AM, Dustin Byford
> <dustin@cumulusnetworks.com> wrote:
> > Add a stub for acpi_preset_companion().  Fixes build failures when
> > acpi_preset_companion() is used and CONFIG_ACPI is not set.
> >
> > Signed-off-by: Dustin Byford <dustin@cumulusnetworks.com>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> > ---
> >  include/linux/acpi.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> > index 51a96a8..66564f8 100644
> > --- a/include/linux/acpi.h
> > +++ b/include/linux/acpi.h
> > @@ -505,6 +505,12 @@ static inline bool has_acpi_companion(struct device *dev)
> >         return false;
> >  }
> >
> > +static inline void acpi_preset_companion(struct device *dev,
> > +                                        struct acpi_device *parent, u64 addr)
> > +{
> > +       return;

But of course, the version without the return statement here is better.

> > +}
> > +
> >  static inline const char *acpi_dev_name(struct acpi_device *adev)
> >  {
> >         return NULL;

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/2] i2c: acpi: scan ACPI enumerated I2C mux channels Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:20 +0200
  [PATCH v4 1/2] acpi: add acpi_preset_companion() stub Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:20 +0200
    Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 10:40 +0200
    Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub "Rafael J. Wysocki" <rafael@kernel.org> - 2015-10-25 14:50 +0100
      Re: [PATCH v4 1/2] acpi: add acpi_preset_companion() stub "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-25 15:40 +0100
  [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Dustin Byford <dustin@cumulusnetworks.com> - 2015-10-22 11:40 +0200
    Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 10:50 +0200
      Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Wolfram Sang <wsa@the-dreams.de> - 2015-10-23 12:20 +0200
        Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 15:20 +0200
          Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-23 15:50 +0200
            Re: [PATCH v4 2/2] i2c: add ACPI support for I2C mux ports Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2015-10-23 16:00 +0200

csiph-web