Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled
Date	2015-10-23 10:30 +0200
Message-ID	<qmFTz-4ff-3@gated-at.bofh.it> (permalink)
References	<qhD61-7Lm-13@gated-at.bofh.it> <qm4r0-8qy-3@gated-at.bofh.it> <qmzXQ-4at-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 23, 2015 at 10:02:11AM +0800, Jiang Liu wrote:
> 	There's another patch already merged into mainstream kernel,
> which solves this issue in another way by making use of
> pci_dev->match_driver flag. Please refer to:
> cbbc00be2ce3 ("iommu/amd: Prevent binding other PCI drivers to IOMMU PCI
> devices")
> 	So I think this patch is redundant now.

Yeah, it fixes the same problem already fixed by your match_driver fix.
But I think this fix makes still sense as it avoids that the problem can
reappear in the future with other drivers. Setting pci_dev->match_driver
could be easily forgotten when writing new code.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Bjorn Helgaas <helgaas@kernel.org> - 2015-10-21 18:30 +0200
  Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Jiang Liu <jiang.liu@linux.intel.com> - 2015-10-23 04:10 +0200
    Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Joerg Roedel <joro@8bytes.org> - 2015-10-23 10:30 +0200

csiph-web