Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254380
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Joerg Roedel <joro@8bytes.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled |
| Date | Fri, 23 Oct 2015 10:30:02 +0200 |
| Message-ID | <qmFTz-4ff-3@gated-at.bofh.it> (permalink) |
| References | <qhD61-7Lm-13@gated-at.bofh.it> <qm4r0-8qy-3@gated-at.bofh.it> <qmzXQ-4at-1@gated-at.bofh.it> |
| X-Original-To | Jiang Liu <jiang.liu@linux.intel.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1445588595; bh=hJK48VB8gFtSX9cUc44XE33Rc/azxEN8c2MP2d1/+eg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hewsnoXhFnexnSe3A9fnQM6ubodNEhcVBbdl2Stxxyr2pNP20EqCC4jaKhvmA0rHt jHgDG3DJqCgmSCDrzGvYKYfjwI/zR+Bc7nSoQuffsf62/YayOd00RjicN+beRG1sCy P/7O0pfsnaZZUfjOQIIWRPRy28/KCNzuDNE1nqSD+oHPF+O6Z3+9ZKHWIIiWMDqhk+ nyA8OEQ/YBm8AmKJUNJZDPMJ9Bb7Q8ODZBTlJDodsFaSGvAo9CQuBATIHHQu2JiLjk EY+XEqXE4c3Z6NUz/9S/8rOsEzNxJUSiu/d1k7Q9gsE9SCpVUlQHcGd5C+UfJcZ5of bRlBMjtLLCIxg== |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 21 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de> |
| X-Original-Date | Fri, 23 Oct 2015 10:23:15 +0200 |
| X-Original-Message-ID | <20151023082314.GW27420@8bytes.org> |
| X-Original-References | <1444386214-26319-1-git-send-email-joro@8bytes.org> <20151021162329.GB1583@localhost> <56299523.1010201@linux.intel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1254380 |
Show key headers only | View raw
On Fri, Oct 23, 2015 at 10:02:11AM +0800, Jiang Liu wrote:
> There's another patch already merged into mainstream kernel,
> which solves this issue in another way by making use of
> pci_dev->match_driver flag. Please refer to:
> cbbc00be2ce3 ("iommu/amd: Prevent binding other PCI drivers to IOMMU PCI
> devices")
> So I think this patch is redundant now.
Yeah, it fixes the same problem already fixed by your match_driver fix.
But I think this fix makes still sense as it avoids that the problem can
reappear in the future with other drivers. Setting pci_dev->match_driver
could be easily forgotten when writing new code.
Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Bjorn Helgaas <helgaas@kernel.org> - 2015-10-21 18:30 +0200
Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Jiang Liu <jiang.liu@linux.intel.com> - 2015-10-23 04:10 +0200
Re: [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Joerg Roedel <joro@8bytes.org> - 2015-10-23 10:30 +0200
csiph-web