Re: [PATCH] i2c: designware: fix platform driver probe rename

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: designware: fix platform driver probe rename
Date	2015-10-21 11:40 +0200
Message-ID	<qlY2d-7mq-13@gated-at.bofh.it> (permalink)
References	<qlXIS-70g-9@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2015-10-21 at 11:16 +0200, Arnd Bergmann wrote:
> A function rename was incomplete and missed the !CONFIG_PM
> case:
> 
> i2c-designware-platdrv.c:340:13: error: 'dw_i2c_plat_prepare'
> undeclared here (not in a function)
> i2c-designware-platdrv.c:341:14: error: 'dw_i2c_plat_complete'
> undeclared here (not in a function)
> 
> This renames the macros accordingly.

Jarkko sent this already couple hours ago.

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6ad6fde3970c ("i2c: designware: Rename platform driver probe
> and PM functions")
> ---
> Found on ARM randconfig builds
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> b/drivers/i2c/busses/i2c-designware-platdrv.c
> index f6b252a8ffd1..eb55760ccd9f 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -307,8 +307,8 @@ static void dw_i2c_plat_complete(struct device
> *dev)
>  		pm_request_resume(dev);
>  }
>  #else
> -#define dw_i2c_prepare	NULL
> -#define dw_i2c_complete	NULL
> +#define dw_i2c_plat_prepare	NULL
> +#define dw_i2c_plat_complete	NULL
>  #endif
>  
>  #ifdef CONFIG_PM
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: designware: fix platform driver probe rename Arnd Bergmann <arnd@arndb.de> - 2015-10-21 11:20 +0200
  Re: [PATCH] i2c: designware: fix platform driver probe rename Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-21 11:40 +0200

csiph-web