Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1252625
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] i2c: designware: fix platform driver probe rename |
| Date | Wed, 21 Oct 2015 11:40:01 +0200 |
| Message-ID | <qlY2d-7mq-13@gated-at.bofh.it> (permalink) |
| References | <qlXIS-70g-9@gated-at.bofh.it> |
| X-Original-To | Arnd Bergmann <arnd@arndb.de>, Wolfram Sang <wsa@the-dreams.de> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.17,711,1437462000"; d="scan'208";a="831579060" |
| Organization | Intel Finland Oy |
| Content-Type | text/plain; charset="UTF-8" |
| X-Mailer | Evolution 3.18.0-2+b1 |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 8bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 48 |
| X-Original-Cc | Jarkko Nikula <jarkko.nikula@linux.intel.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org |
| X-Original-Date | Wed, 21 Oct 2015 12:27:29 +0300 |
| X-Original-Message-ID | <1445419649.22669.32.camel@linux.intel.com> |
| X-Original-References | <4006973.dp9o3gm8C4@wuerfel> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1252625 |
Show key headers only | View raw
On Wed, 2015-10-21 at 11:16 +0200, Arnd Bergmann wrote:
> A function rename was incomplete and missed the !CONFIG_PM
> case:
>
> i2c-designware-platdrv.c:340:13: error: 'dw_i2c_plat_prepare'
> undeclared here (not in a function)
> i2c-designware-platdrv.c:341:14: error: 'dw_i2c_plat_complete'
> undeclared here (not in a function)
>
> This renames the macros accordingly.
Jarkko sent this already couple hours ago.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6ad6fde3970c ("i2c: designware: Rename platform driver probe
> and PM functions")
> ---
> Found on ARM randconfig builds
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> b/drivers/i2c/busses/i2c-designware-platdrv.c
> index f6b252a8ffd1..eb55760ccd9f 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -307,8 +307,8 @@ static void dw_i2c_plat_complete(struct device
> *dev)
> pm_request_resume(dev);
> }
> #else
> -#define dw_i2c_prepare NULL
> -#define dw_i2c_complete NULL
> +#define dw_i2c_plat_prepare NULL
> +#define dw_i2c_plat_complete NULL
> #endif
>
> #ifdef CONFIG_PM
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] i2c: designware: fix platform driver probe rename Arnd Bergmann <arnd@arndb.de> - 2015-10-21 11:20 +0200 Re: [PATCH] i2c: designware: fix platform driver probe rename Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-21 11:40 +0200
csiph-web